-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* feat: add PHP initialization * chore(PHP): implement RoadRunner run command generator * feat(PHP): add ClassLocator; implement Workflow and Activity classes detection and loading * chore(PHP): RoadRunner now is run from PHP script that will start also client code * chore(PHP): implemented checks starting; refactoring; implemented query/successful_query feature * chore(PHP): better notification about failures * fix(PHP): fixed task queue binding and workflow run with correct task queue * chore(PHP): add workflow injector that runs workflow with correct queue and options based on an attribute * feat(PHP): add the RoadRunner runner service to be able to stop and rerun RoadRunner; add `query/timeout_due_to_no_active_workers` feature * chore(PHP): add feature `query/unexpected_arguments` * chore(PHP): finish all the `query` features * chore(PHP): add activity features: `basic_no_workflow_timeout`, `cancel_try_cancel` and `retry_on_error` * chore(PHP): add Child Workflow feature `signal` * chore(PHP): add Child Workflow features: `result` and `throws_on_execute` * chore(PHP): add feature `continue_as_new/continue_as_same` * chore(PHP): add feature `eager_workflow/successful_start"` * feat(PHP): add ability to inject client Interceptor provider via feature attributes * chore(PHP): add feature `data_converter/json` * chore(PHP): add feature `data_converter/json_protobuf` * chore(PHP): add feature `data_converter/empty` * chore(PHP): add feature `data_converter/failure` * feat(PHP): support custom Payload Converters in client and server sides * chore(PHP): add feature `data_converter/codec` * fix(PHP): fix constants conflict in feature files; place binary proto converter after the json proto converter * chore(PHP): add feature `data_converter/binary_protobuf` * chore(PHP): add feature `data_converter/binary` * chore(PHP): add feature `eager_activity/non_remote_activities_worker` * chore(PHP): add feature `schedule\backfill` * chore(PHP): add feature `schedule\basic` * chore(PHP): add feature `schedule\pause` * chore(PHP): add feature `schedule\trigger` * chore(PHP): add feature `signal\activities` * chore(PHP): add feature `signal\basic` * chore(PHP): add feature `signal\child_workflow` * chore(PHP): add feature `signal\external` * chore(PHP): add feature `signal\prevent_close` * chore(PHP): add feature `signal\signal_with_start` * chore(PHP): add case into the `signal\signal_with_start` feature * chore(PHP): add case `update\activities` * chore(PHP): add case `update\async_accepted` * chore(PHP): add case `update/basic` * chore(PHP): add case `update/basic_async` * chore(PHP): add case `update/client_interceptor` * chore(PHP): add case `update/deduplication` * chore(PHP): add case `update/non_durable_reject` * chore(PHP): add case `update/self` * chore(PHP): add case `update/task_failure` * chore(PHP): add case `update/validation_replay` * feat(PHP): configure KV module; add case `update/worker_restart` * chore(PHP): support testing in a separated dir * chore(PHP): add PHP dockerfile; cleanup * chore(PHP): fix PHP dockerfile; add github workflow * chore(PHP): polish update/* tests * chore(PHP): fix todos * chore: Sync with PHP SDK 2.11 * ci: Fix PHP version detection before Docker image building * ci: add commands to build PHP image * ci: add prefix `v` for php-ver input * ci: fix typo * Ignore platform req on composer install * Skip data_converter/failure last check * Skip one of update/task_failure tests * Fix schedule/basic test: add 10 sec timeout to find schedule * Fix installing dependencies on PHP image building * Optimize PHP dockerfile * Mark eager_activity tests skipped * Add GITHUB_TOKEN to download RoadRunner without a limit * Improve comment about BuildPhpProgramOptions.Version * Skip `eager_workflow` test if the server doesn't support it on the ServerCapabilities level * Fix dynamic config values being passed to cli * Replace `frontend` with `system` for `forceSearchAttributesCacheRefreshOnRead`, `enableActivityEagerExecution` and `enableEagerWorkflowStart` options * Include `dynamicconfig` into php docker image --------- Co-authored-by: Spencer Judge <[email protected]>
- Loading branch information
1 parent
d23eb64
commit 5ec93eb
Showing
73 changed files
with
4,594 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| name: PHP Features Testing | ||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| php-repo-path: | ||
| type: string | ||
| default: 'temporal/sdk' | ||
| version: | ||
| required: true | ||
| type: string | ||
| # When true, the default version will be used (actually it's the latest tag) | ||
| version-is-repo-ref: | ||
| required: true | ||
| type: boolean | ||
| features-repo-path: | ||
| type: string | ||
| default: 'temporalio/features' | ||
| features-repo-ref: | ||
| type: string | ||
| default: 'main' | ||
| # If set, download the docker image for server from the provided artifact name | ||
| docker-image-artifact-name: | ||
| type: string | ||
| required: false | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| defaults: | ||
| run: | ||
| working-directory: ./features | ||
| steps: | ||
| - name: Print git info | ||
| run: 'echo head_ref: "$GITHUB_HEAD_REF", ref: "$GITHUB_REF", PHP sdk version: ${{ inputs.version }}' | ||
| working-directory: '.' | ||
|
|
||
| - name: Download docker artifacts | ||
| if: ${{ inputs.docker-image-artifact-name }} | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
| name: ${{ inputs.docker-image-artifact-name }} | ||
| path: /tmp/server-docker | ||
|
|
||
| - name: Load server Docker image | ||
| if: ${{ inputs.docker-image-artifact-name }} | ||
| run: docker load --input /tmp/server-docker/temporal-autosetup.tar | ||
| working-directory: '.' | ||
|
|
||
| - name: Override IMAGE_TAG environment variable | ||
| if: ${{ inputs.docker-image-artifact-name }} | ||
| run: | | ||
| image_tag=latest | ||
| # image_tag won't exist on older builds (like 1.22.0), so default to latest | ||
| if [ -f /tmp/server-docker/image_tag ]; then | ||
| image_tag=$(cat /tmp/server-docker/image_tag) | ||
| fi | ||
| echo "IMAGE_TAG=${image_tag}" >> $GITHUB_ENV | ||
| working-directory: '.' | ||
|
|
||
| - name: Checkout SDK features repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| path: features | ||
| repository: ${{ inputs.features-repo-path }} | ||
| ref: ${{ inputs.features-repo-ref }} | ||
|
|
||
| - uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: '^1.22' | ||
| - name: Setup PHP 8.2 | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: 8.2 | ||
| tools: composer:v2 | ||
| extensions: dom, sockets, grpc, curl, protobuf | ||
| - name: Start containerized server and dependencies | ||
| if: inputs.docker-image-artifact-name | ||
| run: | | ||
| docker compose \ | ||
| -f ./dockerfiles/docker-compose.for-server-image.yaml \ | ||
| -f /tmp/server-docker/docker-compose.yml \ | ||
| up -d temporal-server cassandra elasticsearch | ||
| - name: Run SDK-features tests directly | ||
| if: inputs.docker-image-artifact-name == '' | ||
| run: go run . run --lang php ${{ inputs.docker-image-artifact-name && '--server localhost:7233 --namespace default' || ''}} --version "${{ inputs.version-is-repo-ref && '' || inputs.version }}" | ||
|
|
||
| # Running the tests in their own step keeps the logs readable | ||
| - name: Run containerized SDK-features tests | ||
| if: inputs.docker-image-artifact-name | ||
| run: | | ||
| docker compose \ | ||
| -f ./dockerfiles/docker-compose.for-server-image.yaml \ | ||
| -f /tmp/server-docker/docker-compose.yml \ | ||
| up --no-log-prefix --exit-code-from features-tests-php features-tests-php | ||
| - name: Tear down docker compose | ||
| if: inputs.docker-image-artifact-name && (success() || failure()) | ||
| run: docker compose -f ./dockerfiles/docker-compose.for-server-image.yaml -f /tmp/server-docker/docker-compose.yml down -v |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "path/filepath" | ||
| "github.com/temporalio/features/harness/go/cmd" | ||
| "github.com/temporalio/features/sdkbuild" | ||
| ) | ||
|
|
||
| // PreparePhpExternal prepares a PHP run without running it. The preparer | ||
| // config directory if present is expected to be a subdirectory name just | ||
| // beneath the root directory. | ||
| func (p *Preparer) BuildPhpProgram(ctx context.Context) (sdkbuild.Program, error) { | ||
| p.log.Info("Building PHP project", "DirName", p.config.DirName) | ||
|
|
||
| prog, err := sdkbuild.BuildPhpProgram(ctx, sdkbuild.BuildPhpProgramOptions{ | ||
| DirName: p.config.DirName, | ||
| Version: p.config.Version, | ||
| RootDir: p.rootDir, | ||
| }) | ||
| if err != nil { | ||
| p.log.Error("failed preparing: %w", err) | ||
| return nil, fmt.Errorf("failed preparing: %w", err) | ||
| } | ||
| return prog, nil | ||
| } | ||
|
|
||
| // RunPhpExternal runs the PHP run in an external process. This expects | ||
| // the server to already be started. | ||
| func (r *Runner) RunPhpExternal(ctx context.Context, run *cmd.Run) error { | ||
| // If program not built, build it | ||
| if r.program == nil { | ||
| var err error | ||
| if r.program, err = NewPreparer(r.config.PrepareConfig).BuildPhpProgram(ctx); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| // Compose RoadRunner command options | ||
| args := append( | ||
| []string{ | ||
| // Namespace | ||
| "namespace=" + r.config.Namespace, | ||
| // Server address | ||
| "address=" + r.config.Server, | ||
| }, | ||
| // Features | ||
| run.ToArgs()..., | ||
| ) | ||
| // TLS | ||
| if r.config.ClientCertPath != "" { | ||
| clientCertPath, err := filepath.Abs(r.config.ClientCertPath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| args = append(args, "tls.cert="+clientCertPath) | ||
| } | ||
| if r.config.ClientKeyPath != "" { | ||
| clientKeyPath, err := filepath.Abs(r.config.ClientKeyPath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| args = append(args, "tls.key="+clientKeyPath) | ||
| } | ||
|
|
||
| // Run | ||
| cmd, err := r.program.NewCommand(ctx, args...) | ||
| if err == nil { | ||
| // r.log.Debug("Running PHP separately", "Args", cmd.Args) | ||
| err = cmd.Run() | ||
| } | ||
| if err != nil { | ||
| return fmt.Errorf("failed running: %w", err) | ||
| } | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.