Add support of pod annotations for service job #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeenadeepak
changed the title
debugger24
reviewed
Oct 23, 2023
| @@ -35,6 +35,10 @@ spec: | |||
| app.kubernetes.io/version: {{ .Chart.AppVersion | replace "+" "_" }} | |||
| app.kubernetes.io/component: database | |||
| app.kubernetes.io/part-of: {{ .Chart.Name }} | |||
| annotations: | |||
| {{- with .Values.serviceJob.podAnnotations }} | |||
There was a problem hiding this comment.
What is serviceJob here ?
There was a problem hiding this comment.
"serviceJob" variable refer to properties of "templates/server-job.yaml" file.
Bump OSS to v1.22.4 (temporalio#453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add support for pod annotations
Istio run with each pod due to which one time job/pod are not successfully terminal, istio is not required here as db schema setup and update are one time job, hence skipping istio by adding addition skip parameter.
Why?
Checklist
[Bug] Temporal services are not starting when deployed in istio enabled namespace #353
I have deployed this on eks with istio enabled namespace, and it is working fine.