Remove search attribute registration before starting every workflow #94
Conversation
| return fmt.Errorf("failed to register search attributes: %w", err) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't have the necessary context here. This was added by @Sushisource in #41. Is it not needed for anything?
There was a problem hiding this comment.
Discussed internally. The plan is for applications using omes (such as CI/CD pipelines) to do this.
There was a problem hiding this comment.
We still need some way for this to happen automatically so that when developers come along and want to just run omes than they don't have to interpret why things are failing.
This should be automatically done somewhere in this codebase still. It doesn't have to be here, but I don't want to merge this PR without doing it somewhere else, or, at the bare minimum, documenting the necessity
There was a problem hiding this comment.
wait, but, you've just merged it without those things 😅
There was a problem hiding this comment.
Yeah, I was hoping that at least the scenario requirements would be documented (though would prefer a bootstrapping command). Having an onerous environment setup process harms these kinds of tools.
Omes is supposed to replicate user behavior to generate load on the server. Registering search attributes doesn't belong in the hot path, it should be done as a separate setup step.
See also: #93