Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TS SDK 1.9 #328

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Update to TS SDK 1.9 #328

merged 3 commits into from
Jan 17, 2024

Conversation

mjameswh
Copy link
Contributor

What was changed

  • Updated all @temporalio/* dependencies to ^1.9.0
  • Use Activity exported functions/objects instead of Context.current().something()
  • Use TestWorkflowEnvironment.createLocal instead of createTimeSkipping where possible
  • Remove usage of defaultSinks

lorensr
lorensr approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@lorensr lorensr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current build error should be fixed by merging main

.scripts/list-of-samples.json Outdated
"encryption",
"expense",
"fetch-esm",
"food-delivery",
"grpc-calls",
"hello-world",
"hello-world-esm",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this and the dir.

also, you also needed this change:

https://github.com/temporalio/samples-typescript/pull/327/files#diff-88397926b71aad9ca766a35d4c240f95914117d55d5521d57ebe2ad7b0a390c2

before committing (the commit hook wrote/overwrote some files it shouldn't have in this PR).

@mjameswh mjameswh merged commit c4c25de into temporalio:main Jan 17, 2024
76 checks passed
@mjameswh mjameswh deleted the update-to-190 branch January 17, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorensr lorensr lorensr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjameswh @lorensr