Update-with-start early return sample #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
commented
Dec 11, 2024
dandavison
force-pushed
the
uws-early-return
branch
from
dacba52 to
dae1850
Compare
dandavison
force-pushed
the
uws-early-return
branch
from
dae1850 to
799b8a4
Compare
mjameswh
reviewed
Jan 8, 2025
mjameswh
reviewed
Jan 8, 2025
mjameswh
reviewed
Jan 8, 2025
early-return/src/start-workflow.ts
Outdated
| startWorkflowOperation, | ||
| }); | ||
| const wfHandle = await startWorkflowOperation.workflowHandle(); | ||
| const finalReport = await wfHandle.result(); |
There was a problem hiding this comment.
You should print the early confirmation before awaiting for the workflow completion. Right now, both will display at the same time, which fails to demonstrate the notion of an "early return".
mjameswh
force-pushed
the
uws-early-return
branch
from
d2a6cc2 to
a1ee719
Compare
dandavison
force-pushed
the
uws-early-return
branch
2 times, most recently
from
462b085 to
c41951a
Compare
This reverts commit eb815cf.
dandavison
force-pushed
the
uws-early-return
branch
from
c41951a to
6eb79c6
Compare
mjameswh
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Only did a quick last review, but that looks ok to me. If anything pops up, we'll revisit.
Thanks @dandavison !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot be merged until UwS is released.