fix: use 127.0.0.1 instead of localhost as default HostPort for IPv4 consistency #1957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Updated the
defaultHostPort
constant ininternal/grpc_dialer.go
from:to:
to ensure consistent and reliable connectivity in local development environments across platforms.
Why?
The default HostPort value used when connecting to the Temporal server is set to "localhost:7233". However, "localhost" may resolve to ::1 (IPv6) on some systems, while temporal server start-dev binds only to 127.0.0.1 (IPv4).
This mismatch leads to errors like: