-
Notifications
You must be signed in to change notification settings - Fork 148
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ignore history events with worker_may_ignore: true. (#2000)
## What was changed * Unknown event types with `worker_may_ignore: true` are skipped * All other unknown event types continue to throw * Added new replay tests verifying that `worker_may_ignore` is handled correctly ## Why? The new `worker_may_ignore` flag is intended to mark events that can be handled as no-ops if the SDK doesn't know the event type.
- Loading branch information
1 parent
ad1dabc
commit b182d78
Showing
5 changed files
with
564 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124 changes: 124 additions & 0 deletions
124
temporal-sdk/src/test/java/io/temporal/internal/replay/UnknownHistoryEventReplayerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| /* | ||
| * Copyright (C) 2022 Temporal Technologies, Inc. All Rights Reserved. | ||
| * | ||
| * Copyright (C) 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Modifications copyright (C) 2017 Uber Technologies, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this material except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.temporal.internal.replay; | ||
|
|
||
| import static io.temporal.testing.WorkflowHistoryLoader.readHistoryFromResource; | ||
|
|
||
| import io.temporal.activity.*; | ||
| import io.temporal.client.WorkflowClient; | ||
| import io.temporal.client.WorkflowOptions; | ||
| import io.temporal.common.WorkflowExecutionHistory; | ||
| import io.temporal.testing.TestWorkflowEnvironment; | ||
| import io.temporal.worker.Worker; | ||
| import io.temporal.workflow.*; | ||
| import java.time.Duration; | ||
| import org.junit.*; | ||
| import org.junit.rules.Timeout; | ||
|
|
||
| public class UnknownHistoryEventReplayerTest { | ||
|
|
||
| public static final String TASK_QUEUE = "unknown-history-event"; | ||
| public static final String RES_CLEAN = "testUnknownHistoryEventClean.json"; | ||
| public static final String RES_MAY_IGNORE = "testUnknownHistoryEventMayIgnore.json"; | ||
| public static final String RES_MAY_NOT_IGNORE = "testUnknownHistoryEventMayNotIgnore.json"; | ||
|
|
||
| @Rule public Timeout testTimeout = Timeout.seconds(10); | ||
|
|
||
| private TestWorkflowEnvironment testEnvironment; | ||
| private Worker worker; | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| testEnvironment = TestWorkflowEnvironment.newInstance(); | ||
| worker = testEnvironment.newWorker(TASK_QUEUE); | ||
| worker.registerWorkflowImplementationTypes(MyWorkflowImpl.class); | ||
| worker.registerActivitiesImplementations(new MyActivityImpl()); | ||
| testEnvironment.start(); | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() { | ||
| testEnvironment.close(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRun() { | ||
| WorkflowClient client = testEnvironment.getWorkflowClient(); | ||
| WorkflowOptions options = | ||
| WorkflowOptions.newBuilder().setTaskQueue(TASK_QUEUE).setWorkflowId("plain-run").build(); | ||
| MyWorkflow stub = client.newWorkflowStub(MyWorkflow.class, options); | ||
| stub.execute(); | ||
| WorkflowExecutionHistory history = client.fetchHistory("plain-run"); | ||
| System.out.println(history.toJson(true)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testClean() throws Exception { | ||
| WorkflowExecutionHistory history = readHistoryFromResource(RES_CLEAN); | ||
| worker.replayWorkflowExecution(history); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMayIgnore() throws Exception { | ||
| WorkflowExecutionHistory history = readHistoryFromResource(RES_MAY_IGNORE); | ||
| worker.replayWorkflowExecution(history); | ||
| } | ||
|
|
||
| @Test(expected = RuntimeException.class) | ||
| public void testMayNotIgnore() throws Exception { | ||
| WorkflowExecutionHistory history = readHistoryFromResource(RES_MAY_NOT_IGNORE); | ||
| worker.replayWorkflowExecution(history); | ||
| } | ||
|
|
||
| @WorkflowInterface | ||
| public interface MyWorkflow { | ||
|
|
||
| @WorkflowMethod | ||
| void execute(); | ||
| } | ||
|
|
||
| @ActivityInterface | ||
| public interface MyActivity { | ||
|
|
||
| @ActivityMethod | ||
| void execute(); | ||
| } | ||
|
|
||
| public static class MyWorkflowImpl implements MyWorkflow { | ||
|
|
||
| @Override | ||
| public void execute() { | ||
| MyActivity activity = | ||
| Workflow.newLocalActivityStub( | ||
| MyActivity.class, | ||
| LocalActivityOptions.newBuilder() | ||
| .setScheduleToCloseTimeout(Duration.ofSeconds(1)) | ||
| .build()); | ||
| activity.execute(); | ||
| } | ||
| } | ||
|
|
||
| public static class MyActivityImpl implements MyActivity { | ||
|
|
||
| @Override | ||
| public void execute() {} | ||
| } | ||
| } |
Oops, something went wrong.