Change build_native_images mac runner to macos-13 #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 8, 2024
|
Arguably we should still test on mac arm, but understood it's a larger change to separate testing from building. Also curious if anything has changed with whatever was blocking our ability to have mac arm native executables. |
To be clear we were not really testing on arm mac, we were testing x86 stuff through rosetta
No unfortunately |
Quinn-With-Two-Ns
force-pushed
the
change-build-native-image-mac
branch
from
c6d62f9 to
3eb4db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change build_native_images mac runner to macos-13.
macos-latestnow points toaarch64. Funny enough this doesn't cause an error since outgraalplugin we use only checks for64so still downloads thex86_64toolchain.