Disallow continue as new in update handlers #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Aug 5, 2024
Sushisource
approved these changes
Aug 5, 2024
Comment on lines
24
to
28
| * Thrown when {@link io.temporal.workflow.Workflow#continueAsNew} is called from a location that is | ||
| * not supported. | ||
| * | ||
| * <p>The reason this class extends Error is for application workflow code to not catch it by | ||
| * mistake. The default behavior of the SDK is to block workflow execution while Error is thrown. |
There was a problem hiding this comment.
Suggested change
| * Thrown when {@link io.temporal.workflow.Workflow#continueAsNew} is called from a location that is | |
| * not supported. | |
| * | |
| * <p>The reason this class extends Error is for application workflow code to not catch it by | |
| * mistake. The default behavior of the SDK is to block workflow execution while Error is thrown. | |
| * Thrown when {@link io.temporal.workflow.Workflow#continueAsNew} is called from an unsupported | |
| * location. | |
| * | |
| * <p>This class extends Error so application workflow code won't catch it by | |
| * mistake. The default behavior of the SDK is to block workflow execution while Error is thrown. |
Quinn-With-Two-Ns
force-pushed
the
issue-2093
branch
from
b59cf23 to
bb2179b
Compare
Quinn-With-Two-Ns
force-pushed
the
issue-2093
branch
from
bb2179b to
4ad6e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2068