Access to workflow/activity instance from context #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jan 22, 2025
| @@ -147,4 +147,7 @@ public interface ActivityExecutionContext { | |||
| * an activity. | |||
| */ | |||
| WorkflowClient getWorkflowClient(); | |||
|
|
|||
| /** Get the currently running activity instance. */ | |||
| Object getInstance(); | |||
There was a problem hiding this comment.
General question, is this available in the main execute-activity inbound interceptor? Meaning there's no case where it is null (and Java has no concept of accessing the execution context from inside activity class constructors since users invoke those I assume).
| * @apiNote The instance is only available after it has been initialized. This function will | ||
| * return null if called before the workflow has been initialized. For example, this could | ||
| * happen if the function is called from a {@link WorkflowInit} constructor or {@link | ||
| * io.temporal.common.interceptors.WorkflowInboundCallsInterceptor#init(WorkflowOutboundCallsInterceptor)}. |
There was a problem hiding this comment.
So long as available in execute of this same interceptor, I think we're good
There was a problem hiding this comment.
Yeah in the test I show this is not null in execute
Quinn-With-Two-Ns
force-pushed
the
issue-2361
branch
from
a980aba to
e38806c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide access to workflow/activity instance from their context. There is some subtly around when the workflow instance is created, I tried to document this in the user visible method.
Note: I did not do anything for Nexus here because the
OperationHandleris already passed to the interceptor.closes: #2361