Comment tests that break CI with PHP <8.2

temporalio · Jul 10, 2023 · 31cc90e · 31cc90e
1 parent 3a96106
commit 31cc90e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/tests/Fixtures/src/Activity/Php82TypesActivity.php b/tests/Fixtures/src/Activity/Php82TypesActivity.php
@@ -13,7 +13,8 @@
 
 use Temporal\Activity\ActivityInterface;
 use Temporal\Activity\ActivityMethod;
-
+/*
+todo: uncomment this with min php 8.2 requirement or when we can skip activities loading depending on php version
 #[ActivityInterface(prefix: "Php82.")]
 class Php82TypesActivity
 {
@@ -34,4 +35,4 @@ public function returnFalse(false $value): false
     {
         return $value;
     }
-}
+}*/
diff --git a/tests/Functional/Client/TypedStubTestCase.php b/tests/Functional/Client/TypedStubTestCase.php
@@ -163,15 +163,16 @@ public function testSignalRunningWorkflowWithInheritedSignalViaParentInterface()
 
     /**
      * @requires PHP >= 8.2
+     * todo: uncomment this with min php 8.2 requirement or when we can skip activities loading depending on php version
      */
-    public function testPhp82Types(): void
-    {
-        $client = $this->createClient();
-
-        $workflow = $client->newWorkflowStub(Php82TypesWorkflow::class);
-        $workflowRun = $client->start($workflow);
-        $result = $workflowRun->getResult();
-
-        $this->assertSame([null, true, false], $result);
-    }
+    // public function testPhp82Types(): void
+    // {
+    //     $client = $this->createClient();
+    //
+    //     $workflow = $client->newWorkflowStub(Php82TypesWorkflow::class);
+    //     $workflowRun = $client->start($workflow);
+    //     $result = $workflowRun->getResult();
+    //
+    //     $this->assertSame([null, true, false], $result);
+    // }
 }