Skip to content

Commit

Permalink
Hotfix: remove unnecessary parameter from ScheduleHandle::delete() (#375
Browse files Browse the repository at this point in the history
)
  • Loading branch information
roxblnfk authored Nov 30, 2023
1 parent 3262b60 commit 6504057
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/Client/Schedule/ScheduleHandle.php
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public function unpause(string $note = 'Unpaused via PHP SDK'): void
/**
* Delete the Schedule.
*/
public function delete(string $identity): void
public function delete(): void
{
$request = (new DeleteScheduleRequest())
->setNamespace($this->namespace)
Expand Down
15 changes: 8 additions & 7 deletions src/Client/Schedule/Spec/ScheduleSpec.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@
* ScheduleSpec depends only on its contents and never changes, except that the
* definition of a time zone can change over time (most commonly, when daylight
* saving time policy changes for an area). To create a totally self-contained
* ScheduleSpec, use UTC or include timezone_data.
* For input, you can provide zero or more of: structured_calendar, calendar,
* cron_string, interval, and exclude_structured_calendar, and all of them will
* ScheduleSpec, use UTC or include {@see self::$timezoneData}.
* For input, you can provide zero or more of: structuredCalendar, calendar,
* cronString, interval, and exclude_structured_calendar, and all of them will
* be used (the schedule will take action at the union of all of their times,
* minus the ones that match exclude_structured_calendar).
* On input, calendar and cron_string fields will be compiled into
* structured_calendar (and maybe interval and timezone_name), so if you
* Describe a schedule, you'll see only structured_calendar, interval, etc.
* minus the ones that match excludeStructuredCalendar).
* On input, calendar and cronString fields will be compiled into
* {@see self::structuredCalendarList} (and maybe interval and timezoneName), so if you
* Describe a schedule, you'll see only {@see self::$structuredCalendarList},
* {@see self::$intervalList}, etc.
*
* @psalm-import-type DateIntervalValue from DateInterval
*
Expand Down

0 comments on commit 6504057

Please sign in to comment.