Fix static analysis issues (#392)

temporalio · Jan 18, 2024 · 9de474f · 9de474f
1 parent ba2d5c3
commit 9de474f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.19.0@06b71be009a6bd6d81b9811855d6629b9fe90e1b">
+<files psalm-version="5.20.0@3f284e96c9d9be6fe6b15c79416e1d1903dcfef4">
   <file src="src/Activity.php">
     <ImplicitToStringCast>
       <code>$type</code>
@@ -921,7 +921,7 @@
     <MissingTemplateParam>
       <code>\IteratorAggregate</code>
     </MissingTemplateParam>
-  </file>c
+  </file>
   <file src="src/Internal/Repository/ArrayRepository.php">
     <InvalidReturnStatement>
       <code><![CDATA[$this->entries[$id] ?? null]]></code>

diff --git a/src/Client/Schedule/Spec/ScheduleSpec.php b/src/Client/Schedule/Spec/ScheduleSpec.php
@@ -312,12 +312,13 @@ public function withEndTime(DateTimeInterface|string|null $dateTime): self
      */
     public function withJitter(mixed $interval): self
     {
+        /** @psalm-suppress RiskyTruthyFalsyComparison */
         if (empty($interval)) {
             /** @see self::$jitter */
             return $this->with('jitter', new \DateInterval('PT0S'));
         }
 
-        assert(DateInterval::assert($interval));
+        \assert(DateInterval::assert($interval));
         $interval = DateInterval::parse($interval, DateInterval::FORMAT_SECONDS);
 
         /** @see self::$jitter */

diff --git a/src/Internal/Marshaller/TypeFactory.php b/src/Internal/Marshaller/TypeFactory.php
@@ -87,7 +87,8 @@ public function detect(?\ReflectionType $type): ?string
         }
 
         foreach ($this->matchers as $matcher) {
-            if ($result = $matcher($type)) {
+            $result = $matcher($type);
+            if ($result !== null) {
                 return $result;
             }
         }

diff --git a/src/Worker/WorkerOptions.php b/src/Worker/WorkerOptions.php
@@ -449,7 +449,7 @@ public function withSessionResourceId(?string $identifier): self
     {
         $self = clone $this;
 
-        $self->sessionResourceId = $identifier ?: null;
+        $self->sessionResourceId = $identifier === '' ? null : $identifier;
 
         return $self;
     }