Merge pull request #445: Client: fix connection timeout

temporalio · Jun 3, 2024 · a73b1fb · a73b1fb
2 parents 90d2a77 + 468ac78
commit a73b1fb
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/src/Client/GRPC/Context.php b/src/Client/GRPC/Context.php
@@ -20,6 +20,7 @@
 final class Context implements ContextInterface
 {
     private ?\DateTimeInterface $deadline = null;
+    private ?\DateInterval $timeout = null;
     private array $options = [];
     private array $metadata;
     private RetryOptions $retryOptions;
@@ -41,7 +42,8 @@ public function withTimeout($timeout, string $format = DateInterval::FORMAT_SECO
         $internal = DateInterval::parse($timeout, $format);
 
         $ctx = clone $this;
-        $ctx->deadline = (new \DateTimeImmutable())->add($internal);
+        $ctx->timeout = $internal;
+        $ctx->deadline = null;
 
         return $ctx;
     }
@@ -50,6 +52,7 @@ public function withDeadline(\DateTimeInterface $deadline): self
     {
         $ctx = clone $this;
         $ctx->deadline = $deadline;
+        $ctx->timeout = null;
 
         return $ctx;
     }
@@ -90,7 +93,11 @@ public function getMetadata(): array
 
     public function getDeadline(): ?\DateTimeInterface
     {
-        return $this->deadline;
+        return match (true) {
+            $this->deadline !== null => $this->deadline,
+            $this->timeout !== null => (new \DateTime())->add($this->timeout),
+            default => null,
+        };
     }
 
     public function getRetryOptions(): RetryOptions

diff --git a/tests/Unit/Client/GRPC/BaseClientTestCase.php b/tests/Unit/Client/GRPC/BaseClientTestCase.php
@@ -16,7 +16,6 @@
 use Temporal\Client\GRPC\ContextInterface;
 use Temporal\Client\GRPC\ServiceClient;
 use Temporal\Client\GRPC\StatusCode;
-use Temporal\Common\RetryOptions;
 use Temporal\Exception\Client\ServiceClientException;
 use Temporal\Exception\Client\TimeoutException;
 use Temporal\Internal\Interceptor\Pipeline;
@@ -87,6 +86,30 @@ public function testWithContext(): void
         $this->assertNotSame($client, $client2);
     }
 
+    public function testWithTimeoutDynamicDeadline(): void
+    {
+        $client = $this->createClientMock();
+        $context = $client->getContext()->withTimeout(1.234);
+
+        $this->assertNotSame($context->getDeadline(), $context->getDeadline());
+    }
+
+    public function testContextGetDeadlineWithoutDeadline(): void
+    {
+        $client = $this->createClientMock();
+        $context = $client->getContext();
+
+        $this->assertNull($context->getDeadline());
+    }
+
+    public function testContextGetDeadlineWithStaticDeadline(): void
+    {
+        $client = $this->createClientMock();
+        $context = $client->getContext()->withDeadline(new DateTimeImmutable('+1 second'));
+
+        $this->assertSame($context->getDeadline(), $context->getDeadline());
+    }
+
     public function testWithAuthKey(): void
     {
         $client = $this->createClientMock();