Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SearchAttributes in ChildWorkflow #515

Merged
merged 11 commits into from
Oct 8, 2024
Merged

Fix SearchAttributes in ChildWorkflow #515

merged 11 commits into from
Oct 8, 2024

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Oct 7, 2024

What was changed

Unable to reproduce #498. However, EncodedValues will now throw an OutOfBoundsException, which may help in detecting the error. Some edge cases have also been fixed.

Fixes in SearchAttributes:

Note

Discovered that for ChildWorkflow, we do not use typed SearchAttributes with Payloads.
Need to rethink the old code around SearchAttributes and rewrite it to use EncodedCollection, which is already used in the Schedule API.

Checklist

  1. Closes [Bug] proto_codec_parse_message Empty searchAttributes child workflow #514
  2. How was this tested: autotests

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:46pm

@roxblnfk roxblnfk requested a review from Sushisource October 7, 2024 19:40
@roxblnfk roxblnfk merged commit d789123 into master Oct 8, 2024
3 checks passed
@roxblnfk roxblnfk deleted the fix-encoded-values branch October 8, 2024 05:47
@roxblnfk roxblnfk added this to the 2.11.1 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] proto_codec_parse_message Empty searchAttributes child workflow
2 participants