Fix SearchAttributes in ChildWorkflow #515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Unable to reproduce #498. However, EncodedValues will now throw an OutOfBoundsException, which may help in detecting the error. Some edge cases have also been fixed.
Fixes in SearchAttributes:
MarshalAssocArray
attributeExample for
['foo' => 'bar']
:This has been fixed.
Note
Discovered that for ChildWorkflow, we do not use typed SearchAttributes with Payloads.
Need to rethink the old code around SearchAttributes and rewrite it to use EncodedCollection, which is already used in the Schedule API.
Checklist