Skip to content

Commit

Permalink
CI fix
Browse files Browse the repository at this point in the history
  • Loading branch information
cretz committed Oct 24, 2023
1 parent 0f1a16c commit ca542d6
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 15 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ jobs:
- if: ${{ !endsWith(matrix.os, '-arm') }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python }}
# Due to a yet-uninvestigated change in 3.11.6 that breaks the Rust
# linker on Windows, we are pinning 3.11 to 3.11.5 here
python-version: ${{ matrix.python == '3.11' && '3.11.5' || matrix.python }}
- if: ${{ matrix.os == 'ubuntu-arm' }}
uses: deadsnakes/[email protected]
with:
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -733,8 +733,7 @@ This internally downloads the Temporal time-skipping test server to a temporary
then starts the test server which has special APIs for skipping time.

**NOTE:** The time-skipping test environment does not work on ARM. The SDK will try to download the x64 binary on macOS
for use with the Intel emulator, but for Linux or Windows ARM there will be no proper time-skipping test server at this
time.
for use with the Intel emulator, but for Linux or Windows ARM there is no proper time-skipping test server at this time.

##### Automatic Time Skipping

Expand Down
17 changes: 7 additions & 10 deletions tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -910,10 +910,7 @@ async def test_schedule_backfill(
pytest.skip("Java test server doesn't support schedules")
await assert_no_schedules(client)

# Just in case it's on the minute boundary, move it off
now = datetime.utcnow()
if now.second == 0:
now += timedelta(seconds=1)
begin = datetime(year=2020, month=1, day=20, hour=5)

# Create paused schedule that runs every minute and has two backfills
handle = await client.create_schedule(
Expand All @@ -934,8 +931,8 @@ async def test_schedule_backfill(
),
backfill=[
ScheduleBackfill(
start_at=now - timedelta(minutes=30),
end_at=now - timedelta(minutes=29),
start_at=begin - timedelta(minutes=30),
end_at=begin - timedelta(minutes=29),
overlap=ScheduleOverlapPolicy.ALLOW_ALL,
)
],
Expand All @@ -945,13 +942,13 @@ async def test_schedule_backfill(
# Add two more backfills and and -2m will be deduped
await handle.backfill(
ScheduleBackfill(
start_at=now - timedelta(minutes=4),
end_at=now - timedelta(minutes=2),
start_at=begin - timedelta(minutes=4),
end_at=begin - timedelta(minutes=2),
overlap=ScheduleOverlapPolicy.ALLOW_ALL,
),
ScheduleBackfill(
start_at=now - timedelta(minutes=2),
end_at=now,
start_at=begin - timedelta(minutes=2),
end_at=begin,
overlap=ScheduleOverlapPolicy.ALLOW_ALL,
),
)
Expand Down
3 changes: 1 addition & 2 deletions tests/testing/test_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@ async def test_workflow_env_time_skipping_heartbeat_timeout():
# Check the causes until heartbeat timeout
assert isinstance(err.value.cause, ActivityError)
assert isinstance(err.value.cause.cause, TimeoutError)
assert isinstance(err.value.cause.cause.cause, TimeoutError)
assert err.value.cause.cause.cause.type == TimeoutType.HEARTBEAT
assert err.value.cause.cause.type == TimeoutType.HEARTBEAT


@workflow.defn
Expand Down

0 comments on commit ca542d6

Please sign in to comment.