Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow Update #400
Workflow Update #400
Changes from 25 commits
e839219
cf7cc9b
2b0d6f0
c2281c5
84b909c
d1e0681
713c847
abe36c3
533b9f7
5daec88
668532d
3a9dc2c
6a7c52a
4be97cc
953b8e4
2e54df6
188bf97
03e3197
cc0871d
de98531
afc1807
8b41042
5d2b614
6b0972d
020f663
6670ee5
1731fcf
1c18fc2
fabaecf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmm, I wonder if just altering
update_salutation
to be an update that return the previous salutation part would be enough. Also, I wonder if calling thisupdate_greeting
is descriptive enough. I don't think it matters much. But I will take the approach of return-old-thing in the .NET PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(pedantic, can ignore)