Support for workflow ID conflict policy #579
Conversation
| id_conflict_policy: How already-running workflows of the same ID are | ||
| treated. Default is unspecified which effectively means fail the | ||
| start attempt. This cannot be set if ``id_reuse_policy`` is set | ||
| to terminate if running. |
There was a problem hiding this comment.
Should we just default it to FAIL then? Otherwise we're sort of at the mercy of whatever server feels like, which could either be a good thing or a bad thing depending on how you look at it.
There was a problem hiding this comment.
This is what we wanted to do, but unfortunately we can't. Unfortunately the server in temporalio/temporal#5507 will fail you if you do not set unspecified and you try to set terminate-if-running id reuse policy. This is an admitted unfortunate server case where unspecified is not treated the same as its default.
So if we default this to fail, a user's code that sets id reuse policy to terminate-if-running will start failing (they both cannot be set). This is the rare case where we have to leave it unset/unspecified as the default. This is why I document what the real default is, because users can't see it as the default param option.
What was changed
id_conflict_policyto workflow start/execute and added testChecklist