Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-binaries github workflow #709

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix build-binaries github workflow #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d44ea2
Run on PR
dandavison Dec 19, 2024
e46acdc
Fix wheel building
dandavison Dec 19, 2024
7eb5e9b
Fix cibuildwheel for macos
dandavison Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
branches:
- main
- "releases/*"
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this before merge


jobs:
# Compile the binaries and upload artifacts
Expand All @@ -19,7 +20,7 @@ jobs:
runsOn: ubuntu-24.04-arm64-2-core
- os: macos-intel
package-suffix: macos-amd64
runsOn: macos-12
runsOn: macos-13
- os: macos-arm
package-suffix: macos-aarch64
runsOn: macos-14
Expand Down
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ filterwarnings = [
]

[tool.cibuildwheel]
before-all = "pip install protoc-wheel-0"
# We only want the 3.8 64-bit build of each type. However, due to
# https://github.com/pypa/cibuildwheel/issues/1278, we have to build macOS as
# 3.9 until that is fixed. Our fix-wheel process will rename it to 3.8 and we
Expand All @@ -128,8 +129,12 @@ build-verbosity = "1"

[tool.cibuildwheel.linux]
before-all = "curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y && yum install -y openssl-devel"
before-build = "pip install protoc-wheel-0"
environment = { PATH = "$PATH:$HOME/.cargo/bin", CARGO_NET_GIT_FETCH_WITH_CLI = "true" }

[tool.cibuildwheel.macos]
environment = { MACOSX_DEPLOYMENT_TARGET = "10.12" }

[tool.mypy]
ignore_missing_imports = true
exclude = [
Expand Down
Loading