Use ruff for linting #771
Use ruff for linting #771
Conversation
| import tests.worker.workflow_sandbox.testmodules.invalid_module | ||
| pass |
There was a problem hiding this comment.
Good catch, no this was overzealous ruff check --fix autofixing.
| @@ -194,9 +194,9 @@ | |||
|
|
|||
| # gRPC is optional | |||
| try: | |||
| import grpc | |||
| import grpc # noqa # type: ignore | |||
There was a problem hiding this comment.
Just for my own curiosity, what was failing here that is requiring these two comments?
There was a problem hiding this comment.
temporalio/api/cloud/cloudservice/v1/__init__.py:197:12: F401 `grpc` imported but unused; consider using `importlib.util.find_spec` to test for availability
I've added the error code.
The type: ignore was to silence Pylance in VSCode. However, our pyright lint passes, so I've removed the type: ignore -- I'll add it back in if and when our lint requires it (and perhaps get my IDE type-checking in sync with our CI type-checking)
| # TODO: wat | ||
| f(self, other) # type: ignore # noqa: F821 |
There was a problem hiding this comment.
I do not know what I was thinking here, but it's likely a bug. Would definitely welcome a test that covers this and fixes it to do what it is supposed to.
dandavison
force-pushed
the
maturin
branch
6 times, most recently
from
e89f5b2 to
bc54894
Compare
| @@ -36,7 +36,6 @@ | |||
| import temporalio.api.common.v1 | |||
| import temporalio.common | |||
| from temporalio.api.common.v1 import Payload, Payloads | |||
| from temporalio.api.common.v1 import Payload as AnotherNameForPayload | |||
There was a problem hiding this comment.
This looks like it was deliberate but also appears to have no purpose today.
|
Addressed comment and done another pass over the diff; this should be ready to merge. |
dandavison
force-pushed
the
lint
branch
3 times, most recently
from
87eb719 to
3f1a956
Compare
| @@ -222,7 +220,7 @@ async def test_workflow_info(client: Client, env: WorkflowEnvironment): | |||
| assert info["retry_policy"] == json.loads( | |||
| json.dumps(dataclasses.asdict(retry_policy), default=str) | |||
| ) | |||
| assert uuid.UUID(info["run_id"]).version == 4 | |||
| assert uuid.UUID(info["run_id"]).version == 7 | |||
There was a problem hiding this comment.
The server switched to v7 UUIDs for runID at temporalio/temporal#6933
WISOTT
PR targets
maturinbranch #768