Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-3625: Fix docs for python trip-booking tutorial #309

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

kacperklusek
Copy link
Contributor

@kacperklusek kacperklusek commented Sep 23, 2024

What was changed

This PR fixes following small issues when starting up python tutorial for booking-trip-tutorial

  • removes obsolete, and error producing argument maximum_attempts from activity invocation.
  • the flask api is defined in starter.py file not in run_workflow.py (which doesn't exist)
  • the port for Flask API is 5000 not 3002.
  • typo in virtualenv activation line

Why?

To keep the docs consistent with rest of the code - without having to debug step by step tutorial.

How was this tested:

I went through fixed README and everything seemed to be working without any problem

Any docs updates needed?

docs/tutorials/python/trip-booking-app/code/README.md has been updated as a part of this PR

@kacperklusek kacperklusek requested a review from a team as a code owner September 23, 2024 12:49
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:21pm

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2024

CLA assistant check
All committers have signed the CLA.

@fairlydurable fairlydurable changed the title Fix docs for python trip-booking tutorial EDU-3624: Fix docs for python trip-booking tutorial Dec 2, 2024
@fairlydurable fairlydurable changed the title EDU-3624: Fix docs for python trip-booking tutorial EDU-3625: Fix docs for python trip-booking tutorial Dec 2, 2024
@tomwheeler tomwheeler merged commit 6733878 into temporalio:main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants