Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-3013: Update links for docusaurus #314

Merged
merged 1 commit into from
Oct 1, 2024
Merged

EDU-3013: Update links for docusaurus #314

merged 1 commit into from
Oct 1, 2024

Conversation

fairlydurable
Copy link
Contributor

After insertion of Run Workers with Temporal Cloud for X SDK, re-route so hello -> run workers and run workers -> 101 (with full words instead of the default wording)

Update pagination_next: courses/temporal_101/SDK-NAME in Docusaurus front matter

To review:

  • Confirm hello world's next is workers with cloud.
  • Confirm workers with cloud next is 101
  • Confirm wording is appropriate for each
  • Confirm links are correct within each SDK

After insertion of Run workers with Temporal Cloud for X SDK,
re-route so hello -> run workers and run workers -> 101 (with full words)
@fairlydurable fairlydurable requested a review from a team as a code owner October 1, 2024 17:56
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 5:56pm

@tomwheeler
Copy link
Collaborator

LGTM. I verified each of the items under "to review" and found that they worked as expected for each of the four SDKs referenced in the commit (Go, Java, Python, and TypeScript).

@fairlydurable fairlydurable merged commit 5520fea into main Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants