Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-3019: Clarifies confusion between pem and crt in Cloud Worker #324

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

fairlydurable
Copy link
Contributor

@fairlydurable fairlydurable commented Oct 16, 2024

Java, Go, Python, Typescript

Ticket source: @yuandrew

@fairlydurable fairlydurable requested a review from a team as a code owner October 16, 2024 15:39
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 5:05pm

Copy link

@yuandrew yuandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, besides the one path issue! Once that's fixed, should be good to merge

docs/getting_started/go/run_workers_with_cloud_go/index.md Outdated Show resolved Hide resolved
napcs
napcs previously requested changes Oct 17, 2024
docs/getting_started/go/run_workers_with_cloud_go/index.md Outdated Show resolved Hide resolved
@fairlydurable fairlydurable dismissed napcs’s stale review October 17, 2024 17:16

Change was addressed and resolved. GitHub is being GitHub.

@fairlydurable fairlydurable merged commit 7ac40ce into main Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants