Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build first app go v2 #348

Merged
merged 11 commits into from
Dec 18, 2024
Merged

Build first app go v2 #348

merged 11 commits into from
Dec 18, 2024

Conversation

napcs
Copy link
Contributor

@napcs napcs commented Dec 17, 2024

Prose for Build Temporal App from Scratch in Go, based on previously edited #345

@napcs napcs requested a review from a team as a code owner December 17, 2024 19:35
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:20pm

Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of small things, but a couple of them may be showstoppers.

docs/getting_started/go/hello_world_in_go/index.md Outdated Show resolved Hide resolved
docs/getting_started/go/hello_world_in_go/index.md Outdated Show resolved Hide resolved
docs/getting_started/go/hello_world_in_go/index.md Outdated Show resolved Hide resolved
docs/getting_started/go/hello_world_in_go/index.md Outdated Show resolved Hide resolved
@axfelix
Copy link
Contributor

axfelix commented Dec 18, 2024

Very minor comments, and I see this already has a stamp -- mergeable whenever you see fit.

@napcs napcs merged commit 4c63453 into main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants