Skip to content

Add API key support for the worker-controller #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add API key support for the worker-controller #149

wants to merge 18 commits into from

Conversation

Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Sep 30, 2025 •
edited
Loading

What was changed

  • WISOTT

Why?

  • Extend the controller to users who use API's to connect to Temporal cloud namespaces

Checklist

  1. Closes
    Add API Keys support #144

  2. How was this tested:

  • Added unit tests
  • Ran the controller locally with both API and mTLS auth
  • Existing suite of integration tests
  1. Any docs updates needed?
  • Updated demo README and relevant scripts as they were out of date.

Shivs11
Shivs11 commented Sep 30, 2025
View reviewed changes
Shivs11
Shivs11 commented Sep 30, 2025
View reviewed changes
@Shivs11 Shivs11 marked this pull request as ready for review September 30, 2025 17:17
@Shivs11 Shivs11 requested review from a team and jlegrone as code owners September 30, 2025 17:17
carlydf
carlydf reviewed Oct 7, 2025
View reviewed changes
jacobstr added a commit to jacobstr/temporal-worker-controller that referenced this pull request Oct 7, 2025
@jacobstr
add debug folder for maintainers
e513fce 
Supporting review comments in temporalio#149
which I'd like to see over the line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlydf carlydf carlydf left review comments

@jlegrone jlegrone Awaiting requested review from jlegrone jlegrone is a code owner

+1 more reviewer

@jacobstr jacobstr jacobstr left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shivs11 @jacobstr @carlydf