Skip to content

Commit

Permalink
Quick fix to reconfig maximumHandoverTimeoutSeconds (#7216)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->
Reconfig the maximumHandoverTimeoutSecondto 30s but change the actual
input to 10s for the default tests.

## Why?
<!-- Tell your future self why have you made these changes -->

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
  • Loading branch information
zigeH authored Feb 2, 2025
1 parent 5ad297b commit 458bbe2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion service/worker/migration/handover_workflow.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const (

minimumAllowedLaggingSeconds = 5
maximumAllowedLaggingSeconds = 120
maximumHandoverTimeoutSeconds = 10
maximumHandoverTimeoutSeconds = 30
)

type (
Expand Down
2 changes: 1 addition & 1 deletion service/worker/migration/handover_workflow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func TestHandoverWorkflow(t *testing.T) {
Namespace: "test-ns",
RemoteCluster: "test-remote",
AllowedLaggingSeconds: 10,
HandoverTimeoutSeconds: 30,
HandoverTimeoutSeconds: 10,
})

require.True(t, env.IsWorkflowCompleted())
Expand Down
2 changes: 1 addition & 1 deletion tests/xdc/failover_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2700,7 +2700,7 @@ func (s *FunctionalClustersTestSuite) TestLocalNamespaceMigration() {
Namespace: namespace,
RemoteCluster: s.clusterNames[1],
AllowedLaggingSeconds: 10,
HandoverTimeoutSeconds: 30,
HandoverTimeoutSeconds: 10,
})
s.NoError(err)
err = run5.Get(testCtx, nil)
Expand Down

0 comments on commit 458bbe2

Please sign in to comment.