Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Deployment Workflow ID's #7198

Open
wants to merge 3 commits into
base: versioning-3.1
Choose a base branch
from
Open

Update Deployment Workflow ID's #7198

wants to merge 3 commits into from
+556 −519

Conversation

Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Jan 31, 2025 •
edited
Loading

What changed?

  • Deployment BuildId's are no longer unique across a namespace. The combination of <DeploymentName, BuildID> will be.
  • To account for this, the version workflow's workflowID will contain a concatenation of this (similar to the pre-release stuff)
  • Constraints for not allowing "/" and "__" in deploymentName and buildID respectively
  • Some refactorings involving changing version to buildID wherever it felt most applicable. (Note, there are instances where I chose not to purposely change version to buildID and that's because it felt natural to do so)

Why?

  • Versioning-3.1

How did you test it?

  • Existing suite of tests

Potential risks

Documentation

Is hotfix candidate?

@Shivs11 Shivs11 requested a review from a team as a code owner January 31, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Shivs11