Add workflowUpdateEnabled boolean

server/config/development.yaml

@@ -15,6 +15,7 @@ disableWriteActions: false
 workflowTerminateDisabled: false
 workflowCancelDisabled: false
 workflowSignalDisabled: false
+workflowUpdateDisabled: false
 workflowResetDisabled: false
 batchActionsDisabled: false
 startWorkflowDisabled: false

server/docker/config-template.yaml

@@ -14,6 +14,7 @@ disableWriteActions: {{ default .Env.TEMPORAL_DISABLE_WRITE_ACTIONS "false" }}
 workflowTerminateDisabled: {{ default .Env.TEMPORAL_WORKFLOW_TERMINATE_DISABLED "false" }}
 workflowCancelDisabled: {{ default .Env.TEMPORAL_WORKFLOW_CANCEL_DISABLED "false" }}
 workflowSignalDisabled: {{ default .Env.TEMPORAL_WORKFLOW_SIGNAL_DISABLED "false" }}
+workflowUpdateDisabled: {{ default .Env.TEMPORAL_WORKFLOW_UPDATE_DISABLED "false" }}
 workflowResetDisabled: {{ default .Env.TEMPORAL_WORKFLOW_RESET_DISABLED "false" }}
 batchActionsDisabled: {{ default .Env.TEMPORAL_BATCH_ACTIONS_DISABLED "false" }}
 startWorkflowDisabled: {{ default .Env.TEMPORAL_START_WORKFLOW_DISABLED "false" }}

server/server/api/handler.go

@@ -68,6 +68,7 @@ type SettingsResponse struct {
 	WorkflowTerminateDisabled     bool
 	WorkflowCancelDisabled        bool
 	WorkflowSignalDisabled        bool
+	WorkflowUpdateDisabled        bool
 	WorkflowResetDisabled         bool
 	BatchActionsDisabled          bool
 	StartWorkflowDisabled         bool
@@ -142,6 +143,7 @@ func GetSettings(cfgProvider *config.ConfigProviderWithRefresh) func(echo.Contex
 			WorkflowTerminateDisabled:     cfg.WorkflowTerminateDisabled,
 			WorkflowCancelDisabled:        cfg.WorkflowCancelDisabled,
 			WorkflowSignalDisabled:        cfg.WorkflowSignalDisabled,
+			WorkflowUpdateDisabled:        cfg.WorkflowUpdateDisabled,
 			WorkflowResetDisabled:         cfg.WorkflowResetDisabled,
 			BatchActionsDisabled:          cfg.BatchActionsDisabled,
 			StartWorkflowDisabled:         cfg.StartWorkflowDisabled,

server/server/config/config.go

@@ -56,6 +56,7 @@ type (
 		WorkflowTerminateDisabled bool `yaml:"workflowTerminateDisabled"`
 		WorkflowCancelDisabled    bool `yaml:"workflowCancelDisabled"`
 		WorkflowSignalDisabled    bool `yaml:"workflowSignalDisabled"`
+		WorkflowUpdateDisabled    bool `yaml:"workflowUpdateDisabled"`
 		WorkflowResetDisabled     bool `yaml:"workflowResetDisabled"`
 		// Whether bulk/batch actions are enabled in the UI
 		BatchActionsDisabled bool `yaml:"batchActionsDisabled"`

src/lib/components/workflow-actions.svelte

@@ -22,6 +22,7 @@
   import { workflowResetEnabled } from '$lib/utilities/workflow-reset-enabled';
   import { workflowSignalEnabled } from '$lib/utilities/workflow-signal-enabled';
   import { workflowTerminateEnabled } from '$lib/utilities/workflow-terminate-enabled';
+  import { workflowUpdateEnabled } from '$lib/utilities/workflow-update-enabled';
 
   export let workflow: WorkflowExecution;
   export let namespace: string;
@@ -49,7 +50,7 @@
     namespace,
   );
 
-  $: updateEnabled = workflowSignalEnabled(
+  $: updateEnabled = workflowUpdateEnabled(
     $page.data.settings,
     $coreUser,
     namespace,

src/lib/services/settings-service.ts

@@ -34,6 +34,7 @@ export const fetchSettings = async (request = fetch): Promise<Settings> => {
     workflowTerminateDisabled: !!settingsResponse?.WorkflowTerminateDisabled,
     workflowCancelDisabled: !!settingsResponse?.WorkflowCancelDisabled,
     workflowSignalDisabled: !!settingsResponse?.WorkflowSignalDisabled,
+    workflowUpdateDisabled: !!settingsResponse?.WorkflowUpdateDisabled,
     workflowResetDisabled: !!settingsResponse?.WorkflowResetDisabled,
     batchActionsDisabled: !!settingsResponse?.BatchActionsDisabled,
     startWorkflowDisabled: !!settingsResponse?.StartWorkflowDisabled,

src/lib/svelte-mocks/app/stores.ts

@@ -30,6 +30,7 @@ const settings: Settings = {
   workflowResetDisabled: false,
   workflowCancelDisabled: false,
   workflowSignalDisabled: false,
+  workflowUpdateDisabled: false,
   workflowTerminateDisabled: false,
   hideWorkflowQueryErrors: false,
   notifyOnNewVersion: true,

src/lib/types/global.ts

@@ -88,6 +88,7 @@ export type Settings = {
   workflowTerminateDisabled: boolean;
   workflowCancelDisabled: boolean;
   workflowSignalDisabled: boolean;
+  workflowUpdateDisabled: boolean;
   workflowResetDisabled: boolean;
   hideWorkflowQueryErrors: boolean;
   batchActionsDisabled: boolean;

src/lib/types/index.ts

@@ -253,6 +253,7 @@ export type SettingsResponse = {
   WorkflowTerminateDisabled: boolean;
   WorkflowCancelDisabled: boolean;
   WorkflowSignalDisabled: boolean;
+  WorkflowUpdateDisabled: boolean;
   WorkflowResetDisabled: boolean;
   BatchActionsDisabled: boolean;
   StartWorkflowDisabled: boolean;

src/lib/utilities/get-codec.test.ts

@@ -34,6 +34,7 @@ const defaultSettings = {
   workflowTerminateDisabled: false,
   workflowCancelDisabled: false,
   workflowSignalDisabled: false,
+  workflowUpdateDisabled: false,
   workflowResetDisabled: false,
   batchActionsDisabled: false,
 };

src/lib/utilities/workflow-update-enabled.test.ts

@@ -0,0 +1,75 @@
+import { describe, expect, test } from 'vitest';
+
+import { workflowUpdateEnabled } from './workflow-update-enabled';
+
+describe('workflowUpdateEnabled', () => {
+  const coreUser = {
+    namespaceWriteDisabled: (ns: string) => ns === 'ns-write-disabled',
+  };
+
+  test('returns true when global write actions, signal, and namespace write actions are all enabled', () => {
+    expect(
+      workflowUpdateEnabled(
+        {
+          disableWriteActions: false,
+        },
+        coreUser,
+        'ns-write-enabled',
+      ),
+    ).toBe(true);
+  });
+
+  describe('returns false', () => {
+    test('when write actions are disabled', () => {
+      expect(
+        workflowUpdateEnabled(
+          {
+            disableWriteActions: true,
+            workflowUpdateDisabled: false,
+          },
+          coreUser,
+          'ns-write-enabled',
+        ),
+      ).toBe(false);
+    });
+
+    test('when update is disabled', () => {
+      expect(
+        workflowUpdateEnabled(
+          {
+            disableWriteActions: false,
+            workflowUpdateDisabled: true,
+          },
+          coreUser,
+          'ns-write-enabled',
+        ),
+      ).toBe(false);
+    });
+
+    test('when write actions and update are both disabled', () => {
+      expect(
+        workflowUpdateEnabled(
+          {
+            disableWriteActions: true,
+            workflowUpdateDisabled: true,
+          },
+          coreUser,
+          'ns-write-enabled',
+        ),
+      ).toBe(false);
+    });
+
+    test('when namespace write actions are disabled', () => {
+      expect(
+        workflowUpdateEnabled(
+          {
+            disableWriteActions: false,
+            workflowUpdateDisabled: false,
+          },
+          coreUser,
+          'ns-write-disabled',
+        ),
+      ).toBe(false);
+    });
+  });
+});

src/lib/utilities/workflow-update-enabled.ts

@@ -0,0 +1,14 @@
+import type { CoreUser } from '$lib/models/core-user';
+import type { Settings } from '$lib/types/global';
+
+export const workflowUpdateEnabled = (
+  settings: Settings,
+  coreUser: CoreUser,
+  namespace: string,
+): boolean => {
+  return (
+    !settings.disableWriteActions &&
+    !settings.workflowUpdateDisabled &&
+    !coreUser.namespaceWriteDisabled(namespace)
+  );
+};