Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Accordion component fixes #2494

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Small Accordion component fixes #2494

merged 8 commits into from
Jan 13, 2025

Conversation

laurakwhit
Copy link
Contributor

@laurakwhit laurakwhit commented Jan 10, 2025

Description & motivation 💭

  • Makes caret icon clickable
  • Removes unnecessary description slot
  • Fixes styling of summary slot
  • Removes hover state (but keeps styling for focus-visible) and makes <button/> full width

Screenshots (if applicable) 📸

Screenshot 2025-01-10 at 11 12 24 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-2691

Docs

Any docs updates needed?

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 4:36pm

Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@laurakwhit laurakwhit merged commit 52f083b into main Jan 13, 2025
14 checks passed
@laurakwhit laurakwhit deleted the fix-accordion branch January 13, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants