Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ignite pkg #21

Closed
wants to merge 6 commits into from
Closed

Conversation

mazzy89
Copy link

@mazzy89 mazzy89 commented Nov 1, 2023

No description provided.

@mazzy89
Copy link
Author

mazzy89 commented Nov 1, 2023

	if legacySendCmd {
		ccoptions = append(ccoptions, chaincmd.WithLegacySendCommand())
	}

	switch sdkVersion {
	case "stargate-44":
		ccoptions = append(ccoptions,
			chaincmd.WithVersion(cosmosver.StargateFortyFourVersion),
		)
	case "stargate-40":
		ccoptions = append(ccoptions,
			chaincmd.WithVersion(cosmosver.StargateFortyVersion),
		)
	case "launchpad":
		ccoptions = append(ccoptions,
			chaincmd.WithVersion(cosmosver.MaxLaunchpadVersion),
			chaincmd.WithLaunchpadCLI(appCli),
		)
		if home != "" {
			ccoptions = append(ccoptions, chaincmd.WithLaunchpadCLIHome(home))
		}
	default:
		ccoptions = append(ccoptions,
			chaincmd.WithVersion(cosmosver.Latest),
		)
	}

WithLegacySendCommand does not exist anymore and I guess we can remove it.

Also in the switch clause we can remove the other cases and leave only the default. What do you think @ilgooz?

@jeronimoalbi
Copy link

I believe that the go.mod replace line can be removed:

replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

@mazzy89
Copy link
Author

mazzy89 commented Nov 1, 2023

@jeronimoalbi I've removed it. However there are still other stuff to remove which I would need to have advice.

go.mod Outdated Show resolved Hide resolved
@mazzy89
Copy link
Author

mazzy89 commented Nov 1, 2023

@Pantani I have updated everything and removed the old stuff. Please @Pantani another look.

@mazzy89 mazzy89 requested a review from Pantani November 1, 2023 16:30
@Pantani
Copy link

Pantani commented Nov 1, 2023

@mazzy89 I don't have rights to merge it

@mazzy89
Copy link
Author

mazzy89 commented Nov 1, 2023

@Pantani thanks for the review. It is not clear to me whether we want to merge the changes to the upstream or leave them in the fork. @ilgooz can you advice here?

@mazzy89 mazzy89 closed this Nov 2, 2023
@mazzy89 mazzy89 deleted the update-ignite-pkg branch November 2, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants