Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long overdue refactor #359

Closed
wants to merge 123 commits into from

Merge branch 'faddat/bump-go-and-pebble' of https://github.com/faddat…

fc0fbd3
Select commit
Loading
Failed to load commit list.
Closed

fix: long overdue refactor #359

Merge branch 'faddat/bump-go-and-pebble' of https://github.com/faddat…
fc0fbd3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 26, 2024 in 0s

74.94% (+6.63%) compared to 774cdfe

View this Pull Request on Codecov

74.94% (+6.63%) compared to 774cdfe

Details

Codecov Report

Attention: Patch coverage is 73.70130% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 74.94%. Comparing base (774cdfe) to head (fc0fbd3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   68.30%   74.94%   +6.63%     
==========================================
  Files          27       13      -14     
  Lines        2073      930    -1143     
==========================================
- Hits         1416      697     -719     
+ Misses        586      190     -396     
+ Partials       71       43      -28     
Files Coverage Δ
goleveldb_batch.go 94.44% <ø> (+1.11%) ⬆️
prefixdb.go 71.30% <100.00%> (+7.74%) ⬆️
prefixdb_iterator.go 81.25% <100.00%> (+0.23%) ⬆️
test_helpers.go 100.00% <100.00%> (ø)
util.go 40.00% <100.00%> (+3.33%) ⬆️
db.go 41.17% <50.00%> (+6.17%) ⬆️
goleveldb.go 65.51% <84.21%> (+6.60%) ⬆️
memdb_iterator.go 91.46% <50.00%> (-1.95%) ⬇️
memdb.go 70.65% <71.42%> (+0.38%) ⬆️
pebble.go 70.71% <70.71%> (ø)

... and 3 files with indirect coverage changes

Files Coverage Δ
goleveldb_batch.go 94.44% <ø> (+1.11%) ⬆️
prefixdb.go 71.30% <100.00%> (+7.74%) ⬆️
prefixdb_iterator.go 81.25% <100.00%> (+0.23%) ⬆️
test_helpers.go 100.00% <100.00%> (ø)
util.go 40.00% <100.00%> (+3.33%) ⬆️
db.go 41.17% <50.00%> (+6.17%) ⬆️
goleveldb.go 65.51% <84.21%> (+6.60%) ⬆️
memdb_iterator.go 91.46% <50.00%> (-1.95%) ⬇️
memdb.go 70.65% <71.42%> (+0.38%) ⬆️
pebble.go 70.71% <70.71%> (ø)

... and 3 files with indirect coverage changes