Merge pull request #5 from tenmax/feat/build-variants

feat: apply the publisher ID and space ID for different variants
tenmax · Nov 3, 2024 · 4e85de6 · 4e85de6
2 parents fc0cbf3 + 0ce9cd4
commit 4e85de6
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 15 deletions.
diff --git a/sdkdemo/build.gradle.kts b/sdkdemo/build.gradle.kts
@@ -24,7 +24,8 @@ android {
             resValue("string", "inlineId", "fcc96b4975ff4357")
             resValue("string", "topBannerId", "590bab0f1b6a482f")
             resValue("string", "bottomBannerId", "843e0771ab4c4d9f")
-            resValue("string", "floatingId", "765c489949994641")
+            resValue("string", "floatingId", "75da160bd7164d62")
+            resValue("string", "app_name", "TenMaxMobileSDKDemo")
         }
         release {
             applicationIdSuffix = ".public"
@@ -38,27 +39,31 @@ android {
             resValue("string", "inlineId", "fcc96b4975ff4357")
             resValue("string", "topBannerId", "590bab0f1b6a482f")
             resValue("string", "bottomBannerId", "843e0771ab4c4d9f")
-            resValue("string", "floatingId", "765c489949994641")
+            resValue("string", "floatingId", "75da160bd7164d62")
+            resValue("string", "app_name", "TenMaxMobileSDKDemo")
         }
+        // the following build types are internal use only, please do not use them
         create("cht") {
             initWith(getByName("debug"))
             applicationIdSuffix = ".cht"
-            manifestPlaceholders["publisherId"] = "0fe5b5e7c1"
-            resValue("string", "interstitialId", "3644ec9ebb0d4ed4")
-            resValue("string", "inlineId", "fcc96b4975ff4357")
-            resValue("string", "topBannerId", "590bab0f1b6a482f")
-            resValue("string", "bottomBannerId", "843e0771ab4c4d9f")
-            resValue("string", "floatingId", "765c489949994641")
+            manifestPlaceholders["publisherId"] = "7ac1ab497e"
+            resValue("string", "interstitialId", "aa098c5fdb3c42e8")
+            resValue("string", "inlineId", "53d7675c53c64de6")
+            resValue("string", "topBannerId", "aa7947ea8e104da3")
+            resValue("string", "bottomBannerId", "2b07703707354bd6")
+            resValue("string", "floatingId", "5417d8bf58b34bac")
+            resValue("string", "app_name", "TenMaxMobileSDKDemo (CHT)")
         }
         create("internal") {
             initWith(getByName("debug"))
             applicationIdSuffix = ".internal"
-            manifestPlaceholders["publisherId"] = "0fe5b5e7c1"
-            resValue("string", "interstitialId", "3644ec9ebb0d4ed4")
-            resValue("string", "inlineId", "fcc96b4975ff4357")
-            resValue("string", "topBannerId", "590bab0f1b6a482f")
-            resValue("string", "bottomBannerId", "843e0771ab4c4d9f")
-            resValue("string", "floatingId", "765c489949994641")
+            manifestPlaceholders["publisherId"] = "3a915e28ca"
+            resValue("string", "interstitialId", "cc43cdfb576f4ef1")
+            resValue("string", "inlineId", "537a62f3a29c4a18")
+            resValue("string", "topBannerId", "79eb94fa2a0c40db")
+            resValue("string", "bottomBannerId", "fd1cf37e2c064da8")
+            resValue("string", "floatingId", "77938353b6a04d78")
+            resValue("string", "app_name", "TenMaxMobileSDKDemo (Internal)")
         }
     }
     compileOptions {

diff --git a/sdkdemo/src/main/java/io/tenmax/sdkdemo/ui/dashboard/DashboardFragment.java b/sdkdemo/src/main/java/io/tenmax/sdkdemo/ui/dashboard/DashboardFragment.java
@@ -88,6 +88,10 @@ public void onResume() {
     public void onDestroyView() {
         super.onDestroyView();
         binding = null;
-        cleanAd(this.presentingAd);
+        String type = getArguments().getString("spaceType");
+        // the floating AD would clean up resource on close button pressed
+        if (!"floating".equals(type)) {
+            cleanAd(this.presentingAd);
+        }
     }
 }