Add support for negative values #153
Conversation
A couple of drive-by changes are notable: - Data arrays are now initialized with NaNs, so we don't assume 0s. This used to be harmless while data was nonnegative, but if a function goes negative while initialized-with-0 data is still in the data buffer it becomes visibly wrong without this fix. - The standard math library (-lm) is now used. This could be finessed with biased truncation, but this is clearer. Data is still plotted vertically "up from negative infinity", which is perhaps a little unusual. This is simpler than tracking where the axes should be drawn, and still produces a legible result with axes that don't jump around as the extents of the data change.
There was a problem hiding this comment.
@gsmecher I haven't looked at this in detail yet but I should share that @tenox7 and @edgar-bonet and I are in the process of finishing release 1.6.0 based off branch development not master, ticket #134 has a few details more, we're not far from the finish line (..). It is probably best to get 1.6.0 finished and development merged into master first and then we can see together how to transplant this new support for negative numbers, some of it may already by there from #115 but I haven't had a closer look yet what's in here. Happy to do that after 1.6.0.
Not a problem - this was a quick first run through negative-value support. If you get there first, great - otherwise I'll look at merging or rewriting post-1.6.0. |
|
It says there are conflicts in Makefile and ttyplot.c |
|
I am! My apologies - I'm swamped. I'll find some time soon.
…On Thu, Jan 18, 2024, 5:19 p.m. Sebastian Pipping ***@***.***> wrote:
@gsmecher <https://github.com/gsmecher> with #155
<#155> merged, master would now be
ready for a re-evaluation of support for negative values.
@gsmecher <https://github.com/gsmecher> we haven't heard from you for 3+
weeks now. Are you still interested in this pull request?
—
Reply to this email directly, view it on GitHub
<#153 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEU5DF5CO4TQI42SUC4L3DYPHC37AVCNFSM6AAAAABAXCY7QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGQ4DCOBXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Closed in favour of #169. |
Adds support for negative values. Should clear up #53 and #22.
This is a quick and possibly rough implementation - comments welcome.