Fix shard computation in NoShuffleBeamWriter
with overlapping split names
#11070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
NoShuffleBeamWriter
would compute the wrong number of shards for cases where splits have overlapping names.E.g. given a dataset with two splits
foo
andfoo_bar
the generated tfrecord files would look something like this:The current regex for the
foo
split would bebuilder-foo*
which also matches the files of thefoo_bar
split. This results in the number of shards forfoo
to also include shards from the other split. This fixes it by changing the regex tobuilder-foo.*
.