-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code changes to add PluggableDevice support for Inference #605
base: master
Are you sure you want to change the base?
Conversation
Enable TF_LoadPluggableDeviceLibrary API for PluggableDevices Signed-off-by: rjauhari2 <[email protected]>
Adding this line should have generated more code which needs to be checked in, and we've had issues with the experimental C API in the past. Does this build correctly? |
Hi @Craigacp, I have added the code generated form c_api_experimental.h file. Yes, I was able to build it successfully. I have also tested loading our plugin solution, and tried running few models. |
I also recall trying to enable this experimental API in the past and we were facing compilation issues, maybe it has been cleaned up? But if it now works, that's amazing! I'll run a full build on all supported platforms before merging |
No wait I was wrong, what is missing is the generated classes under this package. @rjauhari2 , can you please commit them as well? It complains about three missing classes: Also, what command did you run to compile it successfully and what's your platform? |
- Add TF_AttrBuilder, TF_ShapeAndTypeList, TF_CheckpointReader classes.
Hi @karllessard, I used "mvn clean install -Pgenerating" command to build TF-Java. I have tested this on "linux-x86_64" machine. Now, I have added the generated class in "c_api" folder. With these changes I am able to build with "mvn clean install". Thanks for your review and guidance. |
Thanks a lot @rjauhari2. Unfortunately, the build failed on Windows, similar to what we've been observing in the past. We'll have to debug this on our side (unless you have access to a Windows machine), so we might want to push changes to your branch. To be continued... |
Thanks for your quick response. I am able to reproduce the error in your CI (GitHub actions). We shall try from our side. |
Enable TF_LoadPluggableDeviceLibrary API for PluggableDevices