Skip to content

Commit

Permalink
Internal change
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 705582910
  • Loading branch information
Matt-Hurd authored and copybara-github committed Dec 12, 2024
1 parent bfa4df9 commit 4d0a1d4
Show file tree
Hide file tree
Showing 71 changed files with 106 additions and 31 deletions.
File renamed without changes.
1 change: 1 addition & 0 deletions frontend/app/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,6 @@ xprof_ng_module(
sass_binary(
name = "app_css",
src = "app.scss",
# stack = False,
sourcemap = False,
)
1 change: 1 addition & 0 deletions frontend/app/components/capture_profile/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ xprof_ng_module(
sass_binary(
name = "capture_profile_css",
src = "capture_profile.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ xprof_ng_module(
sass_binary(
name = "capture_profile_dialog_css",
src = "capture_profile_dialog.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/components/chart/default_data_provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class DefaultDataProvider implements ChartDataProvider {

/** A chart data provider that accepts array data. */
export class ArrayDataProvider extends DefaultDataProvider {
parseData(data: SimpleDataTable|Array<Array<(string | number)>>|null) {
override parseData(data: SimpleDataTable|Array<Array<(string | number)>>|null) {
if (data) {
/* tslint:disable no-any */
this.dataTable = google.visualization.arrayToDataTable(data as any[]);
Expand All @@ -101,7 +101,7 @@ export class ReplicaGroupDataProvider extends DefaultDataProvider {
hloOpNameIndex?: number; // 'hlo_op_expression' column
selfTimeIndex?: number; // 'total_self_time' column

parseData(data: SimpleDataTable) {
override parseData(data: SimpleDataTable) {
const rowWithReplicaGroups: google.visualization.DataObjectRow[] = [];

if (!data || !data.cols || !data.rows) return;
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/chart/org_chart/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ xprof_ng_module(
sass_binary(
name = "org_chart_css",
src = "org_chart.scss",
# stack = False,
sourcemap = False,
)
1 change: 1 addition & 0 deletions frontend/app/components/chart/table/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,6 @@ xprof_ng_module(
sass_binary(
name = "table_css",
src = "table.scss",
# stack = False,
sourcemap = False,
)
1 change: 1 addition & 0 deletions frontend/app/components/controls/category_filter/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ xprof_ng_module(
sass_binary(
name = "category_filter_css",
src = "category_filter.scss",
# stack = False,
sourcemap = False,
)
1 change: 1 addition & 0 deletions frontend/app/components/controls/export_as_csv/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ xprof_ng_module(
sass_binary(
name = "export_as_csv_css",
src = "export_as_csv.scss",
# stack = True,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
2 changes: 2 additions & 0 deletions frontend/app/components/controls/string_filter/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xprof_ng_module(
"string_filter.ng.html",
"string_filter_css",
],
# strict_templates = False,
deps = [
"@npm//@angular/common",
"@npm//@angular/core",
Expand All @@ -26,6 +27,7 @@ xprof_ng_module(
sass_binary(
name = "string_filter_css",
src = "string_filter.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
2 changes: 2 additions & 0 deletions frontend/app/components/dcn_collective_stats/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xprof_ng_module(
":dcn_collective_stats_css",
"dcn_collective_stats.ng.html",
],
# strict_templates = False,
deps = [
"@npm//@angular/common",
"@npm//@angular/core",
Expand All @@ -35,6 +36,7 @@ xprof_ng_module(
sass_binary(
name = "dcn_collective_stats_css",
src = "dcn_collective_stats.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/diagnostics_view/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ xprof_ng_module(
sass_binary(
name = "diagnostics_view_css",
src = "diagnostics_view.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/empty_page/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ xprof_ng_module(
sass_binary(
name = "empty_page_css",
src = "empty_page.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
2 changes: 2 additions & 0 deletions frontend/app/components/framework_op_stats/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ xprof_ng_module(
":framework_op_stats_css",
"framework_op_stats.ng.html",
],
# strict_templates = False,
deps = [
"@npm//@angular/core",
"@npm//@ngrx/store",
Expand Down Expand Up @@ -58,6 +59,7 @@ xprof_ng_module(
sass_binary(
name = "framework_op_stats_css",
src = "framework_op_stats.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xprof_ng_module(
":flop_rate_chart_css",
"flop_rate_chart.ng.html",
],
# strict_templates = False,
deps = [
"@npm//@angular/core",
"@org_xprof//frontend/app/common/interfaces",
Expand All @@ -27,5 +28,6 @@ xprof_ng_module(
sass_binary(
name = "flop_rate_chart_css",
src = "flop_rate_chart.scss",
# stack = False,
sourcemap = False,
)
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ xprof_ng_module(
sass_binary(
name = "model_properties_css",
src = "model_properties.scss",
# stack = False,
sourcemap = False,
)
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ xprof_ng_module(
":operations_table_css",
"operations_table.ng.html",
],
# strict_templates = False,
deps = [
":operations_table_data_provider",
"@npm//@angular/core",
Expand Down Expand Up @@ -42,6 +43,7 @@ ts_library(
sass_binary(
name = "operations_table_css",
src = "operations_table.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class OperationsTableDataProvider extends DefaultDataProvider {
diffData ? new google.visualization.DataTable(diffData) : undefined;
}

process(): google.visualization.DataTable|google.visualization.DataView|null {
override process(): google.visualization.DataTable|google.visualization.DataView|null {
if (!this.dataTable ||
(this.opExecutor !== OpExecutor.DEVICE &&
this.opExecutor !== OpExecutor.HOST)) {
Expand Down Expand Up @@ -115,7 +115,7 @@ export class OperationsTableDataProvider extends DefaultDataProvider {
return dataView;
}

getOptions(): ChartOptions|null {
override getOptions(): ChartOptions|null {
return this.options;
}

Expand Down
2 changes: 2 additions & 0 deletions frontend/app/components/framework_op_stats/stats_table/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xprof_ng_module(
":stats_table_css",
"stats_table.ng.html",
],
# strict_templates = False,
deps = [
":stats_table_data_provider",
"@npm//@angular/core",
Expand Down Expand Up @@ -42,6 +43,7 @@ xprof_ng_module(
sass_binary(
name = "stats_table_css",
src = "stats_table.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class StatsTableDataProvider extends DefaultDataProvider {

private readonly totalOperationsChanged = new EventEmitter<string>();

setChart(chart: ChartClass) {
override setChart(chart: ChartClass) {
this.chart = chart;
google.visualization.events.addListener(
this.chart, 'sort', (event: SortEvent) => {
Expand All @@ -52,7 +52,7 @@ export class StatsTableDataProvider extends DefaultDataProvider {
});
}

parseData(data: SimpleDataTable|Array<Array<(string | number)>>|null) {
override parseData(data: SimpleDataTable|Array<Array<(string | number)>>|null) {
if (!data) return;
const dataTable = new google.visualization.DataTable(data);
if (this.hasDiff && this.diffTable) {
Expand All @@ -68,14 +68,14 @@ export class StatsTableDataProvider extends DefaultDataProvider {
undefined;
}

setFilters(filters: google.visualization.DataTableCellFilter[]) {
override setFilters(filters: google.visualization.DataTableCellFilter[]) {
this.filters = filters;
if (this.dataTable) {
this.update.emit();
}
}

process(): google.visualization.DataTable|google.visualization.DataView|null {
override process(): google.visualization.DataTable|google.visualization.DataView|null {
if (!this.dataTable) {
return null;
}
Expand All @@ -101,7 +101,7 @@ export class StatsTableDataProvider extends DefaultDataProvider {
return dataView;
}

getOptions(): ChartOptions|null {
override getOptions(): ChartOptions|null {
this.options.sortAscending = this.sortAscending;
this.options.sortColumn = this.sortColumn;
return this.options;
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/graph_viewer/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ xprof_ng_module(
sass_binary(
name = "graph_viewer_css",
src = "graph_viewer.scss",
# stack = True,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/graph_viewer/graph_config/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ xprof_ng_module(
sass_binary(
name = "graph_config_css",
src = "graph_config.scss",
# stack = True,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
2 changes: 2 additions & 0 deletions frontend/app/components/hlo_stats/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xprof_ng_module(
":hlo_stats_css",
"hlo_stats.ng.html",
],
# strict_templates = False,
deps = [
"@npm//@angular/core",
"@npm//@angular/forms",
Expand Down Expand Up @@ -44,6 +45,7 @@ xprof_ng_module(
sass_binary(
name = "hlo_stats_css",
src = "hlo_stats.scss",
# stack = True,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/components/hlo_stats/hlo_stats.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export class HloStats extends Dashboard implements OnDestroy {
};
}

updateView() {
override updateView() {
this.dataInfoForTable = {
...this.dataInfoForTable,
filters: this.getFilters(),
Expand Down Expand Up @@ -247,7 +247,7 @@ export class HloStats extends Dashboard implements OnDestroy {
this.dataInfoForTable.dataProvider.notifyCharts();
}

parseData(data: SimpleDataTable | null) {
override parseData(data: SimpleDataTable | null) {
if (!data) return;
// Five charts share one DataProvider. In order to prevent DataTable from
// being created multiple times, it calls DataProvider function directly.
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/inference_profile/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xprof_ng_module(
":inference_profile_css",
"inference_profile.ng.html",
],
# strict_templates = False,
deps = [
"@npm//@angular/common",
"@npm//@angular/core",
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/input_pipeline/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ xprof_ng_module(
sass_binary(
name = "input_pipeline_css",
src = "input_pipeline.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ xprof_ng_module(
sass_binary(
name = "analysis_summary_css",
src = "analysis_summary.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ xprof_ng_module(
":device_side_analysis_detail_css",
"device_side_analysis_detail.ng.html",
],
# strict_templates = False,
deps = [
":device_side_analysis_detail_data_provider",
"@npm//@angular/core",
Expand All @@ -37,6 +38,7 @@ ts_library(
sass_binary(
name = "device_side_analysis_detail_css",
src = "device_side_analysis_detail.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export class DeviceSideAnalysisDetailDataProvider extends DefaultDataProvider {
this.columnIds = columnIds;
}

parseData(data: SimpleDataTable|Array<Array<(string | number)>>|null) {
override parseData(data: SimpleDataTable|Array<Array<(string | number)>>|null) {
if (!data) return;
const dataTable = new google.visualization.DataTable(data);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xprof_ng_module(
":host_side_analysis_detail_css",
"host_side_analysis_detail.ng.html",
],
# strict_templates = False,
deps = [
":host_side_analysis_detail_table_data_provider",
"@npm//@angular/core",
Expand Down Expand Up @@ -40,6 +41,7 @@ xprof_ng_module(
sass_binary(
name = "host_side_analysis_detail_css",
src = "host_side_analysis_detail.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export class HostSideAnalysisDetailTableDataProvider extends
DefaultDataProvider {
private readonly hasHostOpsChanged = new EventEmitter<boolean>();

parseData(data: SimpleDataTable|Array<Array<(string | number)>>|null) {
override parseData(data: SimpleDataTable|Array<Array<(string | number)>>|null) {
if (!data) return;
const dataTable = new google.visualization.DataTable(data);
if (dataTable.getNumberOfRows() < 1) {
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/kernel_stats/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ xprof_ng_module(
sass_binary(
name = "kernel_stats_css",
src = "kernel_stats.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
2 changes: 2 additions & 0 deletions frontend/app/components/kernel_stats/kernel_stats_table/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xprof_ng_module(
":kernel_stats_table_css",
"kernel_stats_table.ng.html",
],
# strict_templates = False,
deps = [
"@npm//@angular/core",
"@npm//@types/google.visualization",
Expand All @@ -26,6 +27,7 @@ xprof_ng_module(
sass_binary(
name = "kernel_stats_table_css",
src = "kernel_stats_table.scss",
# stack = False,
sourcemap = False,
deps = [
"@org_xprof//frontend/app/styles:common",
Expand Down
Loading

0 comments on commit 4d0a1d4

Please sign in to comment.