Internal changes, no-op

PiperOrigin-RevId: 702818939
tensorflow · Dec 4, 2024 · 5e43df1 · 5e43df1
1 parent 87702ec
commit 5e43df1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/plugin/tensorboard_plugin_profile/convert/tf_data_stats_proto_to_gviz_test.py b/plugin/tensorboard_plugin_profile/convert/tf_data_stats_proto_to_gviz_test.py
@@ -161,7 +161,7 @@ def check_data_table(self, table_description, data, data_table, expected):
           expected_value = gviz_api.DataTable.CoerceValue(raw_value, value_type)
           self.assertEqual(expected_value, raw_value)
           if isinstance(expected_value, tuple):
-            # 
+            # TODO(jihochoi): Check the formatted value too.
             expected_value = expected_value[0]
 
           # Check against expected values we have set in our mock table.

diff --git a/plugin/tensorboard_plugin_profile/convert/trace_events_json.py b/plugin/tensorboard_plugin_profile/convert/trace_events_json.py
@@ -72,7 +72,7 @@ def _events(self):
             tid=rid,
             name='thread_sort_index',
             args=dict(sort_index=rid))
-    # 
+    # TODO(sammccall): filtering and downsampling?
     for event in self._proto.trace_events:
       yield self._event(event)
 

diff --git a/plugin/tensorboard_plugin_profile/demo/profile_demo.py b/plugin/tensorboard_plugin_profile/demo/profile_demo.py
@@ -17,7 +17,7 @@
 The data for profile plugin data is not generated by tensorflow workflow at this
 point, so we simply dump the embedded raw data to the log directory.
 
-
+TODO(ioeric): demonstrate how to setup the plugin when API for writing the data
 is available.
 """
 

diff --git a/plugin/tensorboard_plugin_profile/profile_plugin.py b/plugin/tensorboard_plugin_profile/profile_plugin.py
@@ -627,7 +627,7 @@ def data_impl(
     tqx = request.args.get('tqx')
     graph_viewer_options = self._get_graph_viewer_options(request)
     # Host param is used by HLO tools to identify the module.
-    # 
+    # TODO(profiler): Set graph_viewer_options and host parameters only when
     # neded.
     params = {
         'graph_viewer_options': graph_viewer_options,