Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to use the new MDC-based Angular Components. Components migrated: core, autocomplete, form-field, input, select #688

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Sep 14, 2023

Migration to use the new MDC-based Angular Components. Components migrated: core, autocomplete, form-field, input, select

Other Changes

  • Make sure mat-form-field wrapped around selector has "appearance=outline", and leave input wrapper with the default appearance.
  • updated graph viewer view: set responsive width for side-nav and side-content, removed iframe border
  • consolidated string-filter styles: removed tool component specific styles, use base styles from the filter itself
  • updated hlo op profile top op selector: removed slider, change event listener to "change" to make it more responsive
  • Added ".row" class style into common.scss stylesheet. It is noticed that there are many commonly used classes (eg. item-container, row..etc), but each components defines the style for these class by its own, instead of using a commonly shared stylesheet. Considering gradually migrating to common styles.
  • updated stats_table.ng.html, replaced placeholder with mat-label

@copybara-service copybara-service bot force-pushed the test_565192687 branch 4 times, most recently from 6ce8553 to 57d321a Compare September 15, 2023 01:53
@copybara-service copybara-service bot closed this Sep 15, 2023
@copybara-service copybara-service bot deleted the test_565192687 branch September 15, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants