Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal change. Not visible in OSS. #705

Closed
wants to merge 1 commit into from
Closed

Internal change. Not visible in OSS. #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/app/common/interfaces/data_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ declare interface GeneralAnalysisProperty {
remark_color?: string;
remark_text?: string;
power_metrics?: string;
program_goodput_percent?: string;
}
/* tslint:enable */

Expand Down
8 changes: 8 additions & 0 deletions frontend/app/components/overview/performance_summary/performance_summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ export class PerformanceSummary implements OnChanges {
'Percentage of the device time that is busy.';
powerMetricsTooltipMessage =
'Avg/Max power consumption of different components/rails, including max of moving average of window size of 100us/1ms/10ms.';
programGoodputEfficiencyTooltipMessage =
'Efficiency based on the go/effective-flops-usage. (Predicted Execution Time / On-duty Execution Time).';

ngOnChanges(changes: SimpleChanges) {
if (!this.generalAnalysis || !this.inputPipelineAnalysis) {
Expand Down Expand Up @@ -234,6 +236,12 @@ export class PerformanceSummary implements OnChanges {
propertyValues: components,
});
}
this.summaryInfoAfter.push({
title: 'Program Goodput Efficiency',
descriptions: ['higher is better'],
tooltip: this.programGoodputEfficiencyTooltipMessage,
value: generalProps.program_goodput_percent,
});
}

parseGenericData() {
Expand Down
2 changes: 2 additions & 0 deletions plugin/tensorboard_plugin_profile/protobuf/overview_page.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ message OverviewPageAnalysis {
double device_op_time_outside_compilation_percent = 16;
// Percentage of the device time that is in use.
double device_duty_cycle_percent = 17;
// Program Goodput metric in percentage.
double program_goodput_percent = 18;
}

// Overview result for a performance tip to users.
Expand Down