fix redis cluster api: MaccumCommand

[BobLiu20]

Description

Brief Description of the PR:

Fixes # (issue)

Type of change

• [✅] Bug fix
• New Tutorial
• Updated or additional documentation
• Additional Testing
• New Feature

Checklist:

• I've properly formatted my code according to the guidelines
  • By running yapf
  • By running clang-format
• This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

Redis cluster mode: all data need to split by slot. Already test in my redis cluster.

[MoFHeka]

So it's a memory length bug of TF bool type tensor?
LGTM

[rhdong]

Hi @BobLiu20 , thank you for your contribution! There's a c++ format issue need to be processed, you could refer to the code style guide to format them, any problem please feel free to connect us, many thanks! No so sure if you could see the error, just pasted here for your reference.

#16 [clang-format 7/8] RUN python run-clang-format.py                -r                --cli-args=--style=google                --clang-format-executable ./clang-format/clang-format9                /recommenders-addons/tensorflow_recommenders_addons
#16 0.989 --- /recommenders-addons/tensorflow_recommenders_addons/dynamic_embedding/core/kernels/redis_impl/redis_cluster_connection_pool.hpp	(original)
#16 0.989 +++ /recommenders-addons/tensorflow_recommenders_addons/dynamic_embedding/core/kernels/redis_impl/redis_cluster_connection_pool.hpp	(reformatted)
#16 0.989 @@ -1305,12 +1305,14 @@
#16 0.989      std::vector<std::unique_ptr<std::vector<char>>> exists_chars(storage_slice);
#16 0.989      for (unsigned i = 0; i < storage_slice; ++i) {
#16 0.989        if (!exists_split[i].empty()) {
#16 0.989 -        exists_chars[i] = std::make_unique<std::vector<char>>(exists_split[i].size());
#16 0.989 -        std::transform(exists_split[i].begin(), exists_split[i].end(), exists_chars[i]->begin(), [](bool b) {
#16 0.989 -            return static_cast<char>(b);
#16 0.989 -        });
#16 0.989 -
#16 0.989 -        thread_context->HandlePushBack(i, exists_chars[i]->data(), exists_chars[i]->size() * sizeof(char));
#16 0.989 +        exists_chars[i] =
#16 0.989 +            std::make_unique<std::vector<char>>(exists_split[i].size());
#16 0.989 +        std::transform(exists_split[i].begin(), exists_split[i].end(),
#16 0.989 +                       exists_chars[i]->begin(),
#16 0.989 +                       [](bool b) { return static_cast<char>(b); });
#16 0.989 +
#16 0.989 +        thread_context->HandlePushBack(i, exists_chars[i]->data(),
#16 0.989 +                                       exists_chars[i]->size() * sizeof(char));
#16 0.989        }
#16 0.989      }
#16 0.989  
#16 ERROR: process "/bin/sh -c python run-clang-format.py                -r                --cli-args=--style=google                --clang-format-executable ./clang-format/clang-format9                /recommenders-addons/tensorflow_recommenders_addons" did not complete successfully: exit code: 1
------
 > [clang-format 7/8] RUN python run-clang-format.py                -r                --cli-args=--style=google                --clang-format-executable ./clang-format/clang-format9                /recommenders-addons/tensorflow_recommenders_addons:
0.989 +            std::make_unique<std::vector<char>>(exists_split[i].size());
0.989 +        std::transform(exists_split[i].begin(), exists_split[i].end(),
0.989 +                       exists_chars[i]->begin(),
0.989 +                       [](bool b) { return static_cast<char>(b); });
0.989 +
0.989 +        thread_context->HandlePushBack(i, exists_chars[i]->data(),
0.989 +                                       exists_chars[i]->size() * sizeof(char));
0.989        }
0.989      }
0.989  
------
ERROR: failed t

[BobLiu20]

@rhdong Hi, I'm very sorry for the late reply. I have fixed the formatting issue. Please check again thanks.

[MoFHeka]

LGTM

[BobLiu20]

Hi @MoFHeka , Please check again thanks