Skip to content

Commit

Permalink
Updates GH actions upload- and download-artifact to v4 (#6936)
Browse files Browse the repository at this point in the history
As communicated in [this
announcement](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/),
v3 of these actions is deprecated.

I followed [this
example](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact)
matching our use of these actions.
  • Loading branch information
arcra authored Nov 13, 2024
1 parent 71bd61a commit 62931f1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,14 @@ jobs:
bazel run //tensorboard/pip_package:build_pip_package -- /tmp/tb_nightly_pip_package
- name: 'Upload Pip package as an artifact (master branch TF build only)'
# Prevent uploads when running on forks or non-master branch.
#
# Note that upload-artifact GH action, starting in v4, requires the name of the uploaded
# file(s) to be unique per workflow run, so make sure that the name is unique for each
# "matrix" combination for which this is executed.
if: matrix.tf_version_id == 'tf' && github.repository == 'tensorflow/tensorboard' && github.ref == 'refs/heads/master'
uses: actions/upload-artifact@83fd05a356d7e2593de66fc9913b3002723633cb # v3.1.1
uses: actions/upload-artifact@v4
with:
name: tb-nightly
name: tb-nightly_py${{ matrix.python_version }}
path: /tmp/tb_nightly_pip_package/*

build-data-server-pip:
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/nightly-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ jobs:
if: github.repository == 'tensorflow/tensorboard'
steps:
- name: Download pip package
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: tb-nightly
pattern: tb-nightly_py*
# Download all matching artifacts in the same directory (specified by path)
merge-multiple: true
path: wheels
- name: Install Twine
run: pip install twine
Expand Down

0 comments on commit 62931f1

Please sign in to comment.