Skip to content

Commit

Permalink
Hparams: Return empty lists for DataProvider hyperparameter operation…
Browse files Browse the repository at this point in the history
…s. (#6487)

The DataProvider abstract base class is changed to have simple
implementations of both list_hyperparameters() and
read_hyperparameters(). This is to accomodate TensorBoards' DataProvider
implementations that do not currently implement these operations. We
return empty lists in both operations.
  • Loading branch information
bmd3k authored Jul 10, 2023
1 parent 40b9bda commit 862f9bc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tensorboard/data/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ def list_hyperparameters(self, ctx=None, *, experiment_ids):
Raises:
tensorboard.errors.PublicError: See `DataProvider` class docstring.
"""
pass
return []

def read_hyperparameters(self, ctx=None, *, experiment_ids):
"""Read hyperparameter values.
Expand All @@ -411,7 +411,7 @@ def read_hyperparameters(self, ctx=None, *, experiment_ids):
Raises:
tensorboard.errors.PublicError: See `DataProvider` class docstring.
"""
pass
return []


class ExperimentMetadata:
Expand Down

0 comments on commit 862f9bc

Please sign in to comment.