Skip to content

Commit

Permalink
Chore: Change all copybara expects to legacy variants (#6549)
Browse files Browse the repository at this point in the history
## Motivation for features / changes
All the material design components are actually being remapped to the
legacy variants internally this is confusing and has already lead to
issues like the one being fixed by #6547.

Googlers see [cl/558173803](http://cl/558173803) for the build rules
being added internally.

See [cl/559814988](http://cl/559814988) for confidence this will not
break sync
  • Loading branch information
rileyajones authored Aug 24, 2023
1 parent 2a91acc commit 9b94eeb
Show file tree
Hide file tree
Showing 18 changed files with 116 additions and 116 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ tf_ng_module(
"//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/store",
"//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/store:types",
"//tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_slider",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_slider",
"@npm//@angular/common",
"@npm//@angular/core",
"@npm//@ngrx/store",
Expand Down
8 changes: 4 additions & 4 deletions tensorboard/webapp/alert/views/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ tf_ng_module(
"//tensorboard/webapp/alert:types",
"//tensorboard/webapp/alert/store",
"//tensorboard/webapp/alert/store:types",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_snackbar",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_snackbar",
"//tensorboard/webapp/util:string",
"@npm//@angular/common",
"@npm//@angular/core",
Expand All @@ -49,8 +49,8 @@ tf_ts_library(
"//tensorboard/webapp/alert/store:testing",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_snackbar",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_snackbar",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
"@npm//@angular/core",
Expand Down
42 changes: 21 additions & 21 deletions tensorboard/webapp/angular/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/autocomplete dependency.
tf_ts_library(
name = "expect_angular_material_autocomplete",
name = "expect_angular_legacy_material_autocomplete",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -87,7 +87,7 @@ tf_ts_library(
],
)

# This is a dummy rule used as a @angular/material/legeacy_checkbox dependency.
# This is a dummy rule used as a @angular/material/legacy_checkbox dependency.
tf_ts_library(
name = "expect_angular_legacy_material_checkbox",
srcs = [],
Expand All @@ -107,7 +107,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/button dependency.
tf_ts_library(
name = "expect_angular_material_button",
name = "expect_angular_legacy_material_button",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -125,7 +125,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/chips dependency.
tf_ts_library(
name = "expect_angular_material_chips",
name = "expect_angular_legacy_material_chips",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -134,7 +134,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/dialog dependency.
tf_ts_library(
name = "expect_angular_material_dialog",
name = "expect_angular_legacy_material_dialog",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -143,7 +143,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/dialog/testing dependency.
tf_ts_library(
name = "expect_angular_material_dialog_testing",
name = "expect_angular_legacy_material_dialog_testing",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -152,7 +152,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/expansion dependency.
tf_ts_library(
name = "expect_angular_material_expansion",
name = "expect_angular_legacy_material_expansion",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -161,7 +161,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/expansion dependency.
tf_ts_library(
name = "expect_angular_material_form_field",
name = "expect_angular_legacy_material_form_field",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -188,7 +188,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/input dependency.
tf_ts_library(
name = "expect_angular_material_input",
name = "expect_angular_legacy_material_input",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -197,7 +197,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/menu dependency.
tf_ts_library(
name = "expect_angular_material_menu",
name = "expect_angular_legacy_material_menu",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -206,7 +206,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/menu/testing dependency.
tf_ts_library(
name = "expect_angular_material_menu_testing",
name = "expect_angular_legacy_material_menu_testing",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -215,7 +215,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/paginator dependency.
tf_ts_library(
name = "expect_angular_material_paginator",
name = "expect_angular_legacy_material_paginator",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -224,7 +224,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/progress_spinner dependency.
tf_ts_library(
name = "expect_angular_material_progress_spinner",
name = "expect_angular_legacy_material_progress_spinner",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -233,7 +233,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/select dependency.
tf_ts_library(
name = "expect_angular_material_select",
name = "expect_angular_legacy_material_select",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -242,7 +242,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/select/testing dependency.
tf_ts_library(
name = "expect_angular_material_select_testing",
name = "expect_angular_legacy_material_select_testing",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -251,7 +251,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/slide_toggle dependency.
tf_ts_library(
name = "expect_angular_material_slide_toggle",
name = "expect_angular_legacy_material_slide_toggle",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -260,7 +260,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/slider dependency.
tf_ts_library(
name = "expect_angular_material_slider",
name = "expect_angular_legacy_material_slider",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -269,7 +269,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/snackbar dependency.
tf_ts_library(
name = "expect_angular_material_snackbar",
name = "expect_angular_legacy_material_snackbar",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -287,7 +287,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/table dependency.
tf_ts_library(
name = "expect_angular_material_table",
name = "expect_angular_legacy_material_table",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -296,7 +296,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/tabs dependency.
tf_ts_library(
name = "expect_angular_material_tabs",
name = "expect_angular_legacy_material_tabs",
srcs = [],
deps = [
"@npm//@angular/material",
Expand All @@ -314,7 +314,7 @@ tf_ts_library(

# This is a dummy rule used as a @angular/material/tooltip dependency.
tf_ts_library(
name = "expect_angular_material_tooltip",
name = "expect_angular_legacy_material_tooltip",
srcs = [],
deps = [
"@npm//@angular/material",
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/core/views/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ tf_ng_module(
],
assets = [":layout_styles"],
deps = [
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/core:state",
"//tensorboard/webapp/core:types",
Expand Down
10 changes: 5 additions & 5 deletions tensorboard/webapp/feature_flag/views/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ tf_ng_module(
":feature_flag_dialog",
"//tensorboard/webapp:app_state",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
"//tensorboard/webapp/feature_flag/actions",
"//tensorboard/webapp/feature_flag/store",
"@npm//@angular/common",
Expand All @@ -48,8 +48,8 @@ tf_ng_module(
],
deps = [
"//tensorboard/webapp:app_state",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
"//tensorboard/webapp/feature_flag:types",
"//tensorboard/webapp/feature_flag/actions",
"//tensorboard/webapp/feature_flag/store",
Expand All @@ -76,8 +76,8 @@ tf_ng_module(
"//tensorboard/webapp/angular:expect_angular_cdk_testing",
"//tensorboard/webapp/angular:expect_angular_cdk_testing_testbed",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_dialog_testing",
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
"//tensorboard/webapp/feature_flag:types",
Expand Down
16 changes: 8 additions & 8 deletions tensorboard/webapp/header/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ tf_ng_module(
],
deps = [
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_menu",
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
"//tensorboard/webapp/angular:expect_angular_legacy_material_tabs",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_menu",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_material_tabs",
"//tensorboard/webapp/angular:expect_angular_material_toolbar",
"//tensorboard/webapp/core",
"//tensorboard/webapp/core/actions",
Expand Down Expand Up @@ -70,10 +70,10 @@ tf_ts_library(
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_menu",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_material_tabs",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_menu",
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
"//tensorboard/webapp/angular:expect_angular_legacy_material_tabs",
"//tensorboard/webapp/angular:expect_angular_material_toolbar",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
Expand Down
40 changes: 20 additions & 20 deletions tensorboard/webapp/metrics/views/card_renderer/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ tf_ng_module(
deps = [
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_input",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
"//tensorboard/webapp/angular:expect_angular_legacy_material_input",
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
"//tensorboard/webapp/feature_flag/directives",
"//tensorboard/webapp/metrics:types",
"//tensorboard/webapp/metrics/data_source",
Expand Down Expand Up @@ -106,9 +106,9 @@ tf_ng_module(
":vis_linked_time_selection_warning",
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
"//tensorboard/webapp/metrics:types",
"//tensorboard/webapp/metrics/actions",
"//tensorboard/webapp/metrics/data_source",
Expand Down Expand Up @@ -155,10 +155,10 @@ tf_ng_module(
":utils",
":vis_linked_time_selection_warning",
"//tensorboard/webapp:app_state",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
"//tensorboard/webapp/angular:expect_angular_legacy_material_slider",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
"//tensorboard/webapp/angular:expect_angular_material_slider",
"//tensorboard/webapp/feature_flag/directives",
"//tensorboard/webapp/metrics:types",
"//tensorboard/webapp/metrics/actions",
Expand Down Expand Up @@ -332,11 +332,11 @@ tf_ng_module(
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
"//tensorboard/webapp/angular:expect_angular_legacy_material_menu",
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_menu",
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
"//tensorboard/webapp/experiments:types",
"//tensorboard/webapp/feature_flag/store",
"//tensorboard/webapp/metrics:types",
Expand Down Expand Up @@ -449,13 +449,13 @@ tf_ts_library(
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_input",
"//tensorboard/webapp/angular:expect_angular_material_menu",
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_material_slider",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_dialog",
"//tensorboard/webapp/angular:expect_angular_legacy_material_input",
"//tensorboard/webapp/angular:expect_angular_legacy_material_menu",
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
"//tensorboard/webapp/angular:expect_angular_legacy_material_select",
"//tensorboard/webapp/angular:expect_angular_legacy_material_slider",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
"//tensorboard/webapp/experiments:types",
Expand Down
12 changes: 6 additions & 6 deletions tensorboard/webapp/metrics/views/main_view/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ tf_ng_module(
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_cdk_scrolling",
"//tensorboard/webapp/angular:expect_angular_material_autocomplete",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_autocomplete",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_input",
"//tensorboard/webapp/angular:expect_angular_legacy_material_progress_spinner",
"//tensorboard/webapp/angular:expect_angular_material_button_toggle",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_input",
"//tensorboard/webapp/angular:expect_angular_material_progress_spinner",
"//tensorboard/webapp/customization",
"//tensorboard/webapp/metrics:types",
"//tensorboard/webapp/metrics:utils",
Expand Down Expand Up @@ -185,8 +185,8 @@ tf_ts_library(
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_cdk_scrolling",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_autocomplete",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_legacy_material_autocomplete",
"//tensorboard/webapp/angular:expect_angular_legacy_material_button",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
"//tensorboard/webapp/app_routing",
Expand Down
Loading

0 comments on commit 9b94eeb

Please sign in to comment.