Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hparams: Fix internal Builder failure for test. #6545

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

bmd3k
Copy link
Contributor

@bmd3k bmd3k commented Aug 15, 2023

Googlers, see cl/557139147 for failure.

The CL's presubmit passes because the tests are not run but fixing the Builder failures seems like good hygiene.

@bmd3k bmd3k requested a review from rileyajones August 15, 2023 15:59
Copy link
Contributor

@rileyajones rileyajones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this passed in OSS. Did you try building this internally?

@bmd3k
Copy link
Contributor Author

bmd3k commented Aug 15, 2023

I'm surprised this passed in OSS. Did you try building this internally?

I did. Without this PR it failed. With this PR it succeeded.

@bmd3k bmd3k merged commit 42545de into tensorflow:master Aug 15, 2023
13 checks passed
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Aug 25, 2023
Googlers, see cl/557139147 for failure.

The CL's presubmit passes because the tests are not run but fixing the
Builder failures seems like good hygiene.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants