Hparams: refactor arguments provided to getDashboardRuns
#6555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
changed the title
getDashboardRuns
rileyajones
commented
Aug 22, 2023
| @@ -292,12 +286,8 @@ export const getAllPotentialColumnsForCard = memoize((cardId: string) => { | |||
| ); | |||
| }); | |||
|
|
|||
| export const factories = { | |||
There was a problem hiding this comment.
This was being used to mock selector factories in tests. Now there aren't any so this is unneeded.
| expect(exp2Result[1].run).toEqual({...run3, experimentId: 'exp2'}); | ||
| expect(exp2Result[2].run).toEqual({...run4, experimentId: 'exp2'}); | ||
| it('returns all runs associated with each experiment', () => { | ||
| state.app_routing!.activeRoute!.routeKind = RouteKind.COMPARE_EXPERIMENT; |
There was a problem hiding this comment.
I recognize that this style of mocking the state is potentially controversial. This is the way it has been done in this test file up until now so I'd like to continue the practice until we make a decision around which approach to take in the future.
| @@ -29,6 +29,7 @@ import {createGroupBy} from './utils'; | |||
| import {ColumnHeader, SortingInfo} from '../../widgets/data_table/types'; | |||
| import {getDashboardRunsToHparamsAndMetrics} from '../../hparams/_redux/hparams_selectors'; | |||
| import {RunToHparamsAndMetrics} from '../../hparams/types'; | |||
| import {getExperimentIdsFromRoute} from '../../app_routing/store/app_routing_selectors'; | |||
There was a problem hiding this comment.
Note: that this does create a cross state dependency on the app_routing state. I personally find this to be fine.
bmd3k
reviewed
Aug 22, 2023
| @@ -61,3 +62,22 @@ export const getExperimentNames = (experimentIds: string[]) => | |||
| return map; | |||
| }, {} as Record<string, string>) | |||
| ); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Can the original getExperimentNames be deleted?
If not:
- Can you explain in the comment where/when it is used?
- Can it share some logic with the new getDashboardExperimentNames?
There was a problem hiding this comment.
Yes it can, good point
bmd3k
approved these changes
Aug 23, 2023
tensorboard/webapp/experiments/store/experiments_selectors_test.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/metrics/views/main_view/common_selectors_test.ts
Outdated
Show resolved
Hide resolved
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Aug 25, 2023
…w#6555) ## Motivation for features / changes As per a discussion around tensorflow#6544 we determined that the dashboard should not be requesting runs per experiment but should instead be getting all runs for all experiments shown. This greatly simplifies a lot of the logic used to retrieve runs and run related data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
As per a discussion around #6544 we determined that the dashboard should not be requesting runs per experiment but should instead be getting all runs for all experiments shown.
This greatly simplifies a lot of the logic used to retrieve runs and run related data.