Bug Fix change run effects to use combine latest instead of forkjoin #6568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
approved these changes
Sep 6, 2023
rileyajones
added a commit
that referenced
this pull request
Sep 7, 2023
…6571) ## Motivation for features / changes #6561 created issues when syncing internally. When we discovered the problem we tried to patch forward twice * #6566 * #6568 There was a couple of issues. * Improper support for tuples internally. * Internally `forkJoin` and `zip` work differently, it's not document how though. * The unapproved screenshot changes in [cl/563231334](http://cl/563231334) Googlers see [cl/563516101](http://cl/563516101) for confidence this ACTUALLY fixes the sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
zipandforkJoinwork somewhat differently internally so these observables simply aren't emitting and thus break our sync.Googlers see cl/562877415 for the breakage and cl/cl/563214152 as proof that this works.
#6566 #6488