Hparams: Set interval domain fields for float summary hparams. #6574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatbear
requested review from
bmd3k and
rileyajones
and removed request for
rileyajones
rileyajones
approved these changes
Sep 12, 2023
bmd3k
approved these changes
Sep 12, 2023
| if result.type == api_pb2.DATA_TYPE_FLOAT64: | ||
| # Always uses interval domain type for numeric hparam values. | ||
| distinct_float_values = sorted( | ||
| [v.number_value for v in values if v.HasField("number_value")] |
There was a problem hiding this comment.
Is the if v.HasField("number_value") necessary? Seems like the logic L312 to L322 assures that if result.type == api_pb2.DATA_TYPE_FLOAT64 then all the values have a number_value field.
There was a problem hiding this comment.
Great point! Removed the field check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently TF summary written hparams with
DATA_TYPE_FLOAT64value type have no domain types.#hparams