Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hparams: Avoid retrieving metrics when populating timeseries runs table with hparams. #6678

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

bmd3k
Copy link
Contributor

@bmd3k bmd3k commented Nov 7, 2023

The runs table does not display any of the metric fields/data returned by the hparams plugin. We want to avoid unnecessarily calculating this data on the backend.

The hparams plugin allows requests to specify an include_metrics parameter (added in #6556). We set this flag to false for all hparams-related requests coming from the "hparams_data_source".

Testing:

  • Observed in both OSS and internal TensorBoard that setting this flag to False results in responses that do not include the metric data.
  • Observed that hparams in timeseries runs table still works.
  • Observed that hparams in experiment list runs table still works.

@bmd3k bmd3k requested a review from rileyajones November 7, 2023 21:00
@bmd3k bmd3k merged commit 1346620 into tensorflow:master Nov 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants