Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMSIS-NN Min Max int8 support #2753

Merged
merged 3 commits into from
Feb 5, 2025
Merged

CMSIS-NN Min Max int8 support #2753

merged 3 commits into from
Feb 5, 2025

Conversation

ArmRyan
Copy link
Contributor

@ArmRyan ArmRyan commented Nov 7, 2024

  • Moves common functions to new maximum_minimum.h
  • Creates cmsis-nn/maximum_minimum.cc

BUG=#2752
Change-Id: Ifbb3fedf53043b2f8d4c48d73c2ca44c7f0f87ca

@ArmRyan
CMSIS-NN Min Max int8 support
4377f8c 
  * Moves common functions to new maximum_minimum.h
  * Creates cmsis-nn/maximum_minimum.cc

Change-Id: Ifbb3fedf53043b2f8d4c48d73c2ca44c7f0f87ca
Signed-off-by: Ryan O'Shea <[email protected]>
@ArmRyan ArmRyan requested a review from a team as a code owner November 7, 2024 09:20
@mansnils mansnils added the ci:run label Nov 7, 2024
@mansnils mansnils requested a review from suleshahid November 7, 2024 10:09
@TFLM-bot TFLM-bot removed the ci:run label Nov 7, 2024
@mansnils
Copy link
Contributor

CMSIS-NN SHA is already up to date so cmsis_nn_download.sh script should not be updated. Preferably quant specific registration should also be supported.

@mansnils mansnils added the ci:run label Dec 3, 2024
@TFLM-bot TFLM-bot removed the ci:run label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Jan 13, 2025
@ArmRyan
Copy link
Contributor Author

ArmRyan commented Jan 16, 2025

commenting to remove stale

@github-actions github-actions bot removed the Stale label Jan 16, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #2753 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: 19 of 20 required status checks are expected.)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit 740cef3 into tensorflow:main Feb 5, 2025
98 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suleshahid suleshahid suleshahid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArmRyan @mansnils @suleshahid @TFLM-bot