Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No panic on create tasks if the graph ctx is none #1068

Merged
merged 2 commits into from
Dec 2, 2024
Merged

No panic on create tasks if the graph ctx is none #1068

merged 2 commits into from
Dec 2, 2024

Conversation

seriousben
Copy link
Member

@seriousben seriousben commented Nov 26, 2024 •
edited
Loading

Context

Fixes #1067

What

Removing unwraps in start_tasks and replay_compute_graph.

Testing

Using the graph behavior test.

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

@seriousben seriousben requested a review from diptanu November 26, 2024 17:11
diptanu
diptanu requested changes Dec 1, 2024
View reviewed changes
server/state_store/src/state_machine.rs Outdated Show resolved Hide resolved
@seriousben seriousben force-pushed the seriousben/no-panic-on-create-tasks branch 2 times, most recently from bd4c690 to d141c39 Compare December 2, 2024 02:46
@seriousben seriousben force-pushed the seriousben/no-panic-on-create-tasks branch from d141c39 to 9bf00b6 Compare December 2, 2024 02:46
@seriousben seriousben requested a review from diptanu December 2, 2024 02:48
@diptanu diptanu merged commit 4202a29 into main Dec 2, 2024
5 checks passed
@diptanu diptanu deleted the seriousben/no-panic-on-create-tasks branch December 2, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptanu diptanu Awaiting requested review from diptanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server: create_tasks can panic if graph invocation ctx does not exist
2 participants
@seriousben @diptanu